Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(app): ensure terminal run preview shows detail for load liquid commands #15120

Merged
merged 1 commit into from
May 8, 2024
Merged

fix(app): ensure terminal run preview shows detail for load liquid commands #15120

merged 1 commit into from
May 8, 2024

Conversation

ncdiehl11
Copy link
Collaborator

@ncdiehl11 ncdiehl11 commented May 7, 2024 •
edited
Loading

closes RQA-2645
closes RQA-2647

Overview

After a terminal run, we access the run record's data for commands, labware, pipettes, and modules. We need to extend this to liquids so that the liquid's ID from its load command matches that on the analysis-like object passed to command text.

Test Plan

  • Run a protocol that loads at least one liquid (example linked as rtp_tests.py here)
  • Verify that run log before and during run shows full detail for load liquid command
  • Cancel or finish run and verify that run log still shows full detail for load liquid command

Before fix (see command 4):

Screenshot 2024-05-07 at 3 05 37 PM

After fix (see command 4):

Screenshot 2024-05-07 at 3 05 13 PM

Changelog

  • pull liquids from run record for terminal run to pass to CommandText in RunPreview
  • update Run interface to include liquids to reflect actual robot server response shape
  • update Run fixtures to include liquids key

Review requests

auth js

Risk assessment

low

@ncdiehl11
fix(app): ensure terminal run preview shows detail for load liquid co…
3090f18 
…mmands

After a terminal run, we access the run record's data for commands, labware, pipettes, and modules.
We need to extend this to liquids so that the liquid's ID from its load command matches that on the
analysis-like object passed to command text.
@ncdiehl11 ncdiehl11 self-assigned this May 7, 2024
@ncdiehl11 ncdiehl11 marked this pull request as ready for review May 7, 2024 19:08
@ncdiehl11 ncdiehl11 requested a review from a team as a code owner May 7, 2024 19:08
koji
koji approved these changes May 8, 2024
View reviewed changes
Copy link
Contributor

@koji koji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the changes look good to me.

@ncdiehl11 ncdiehl11 merged commit ef7a0d8 into chore_release-7.3.0 May 8, 2024
32 checks passed
@ncdiehl11 ncdiehl11 deleted the fix_app-runlog-liquids branch May 8, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koji koji koji approved these changes

@shlokamin shlokamin Awaiting requested review from shlokamin

@jerader jerader Awaiting requested review from jerader

Assignees

@ncdiehl11 ncdiehl11

Labels
authorship
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ncdiehl11 @koji