fix(app): ensure terminal run preview shows detail for load liquid co…

…mmands (#15120) RQA-2645 RQA-2647
Opentrons · May 8, 2024 · ef7a0d8 · ef7a0d8
1 parent 16b94b5
commit ef7a0d8
Show file tree

Hide file tree

Showing 5 changed files with 22 additions and 0 deletions.
diff --git a/api-client/src/runs/types.ts b/api-client/src/runs/types.ts
@@ -1,4 +1,5 @@
 import type {
+ Liquid,
  LoadedLabware,
  LoadedModule,
  LoadedPipette,
@@ -46,6 +47,7 @@ export interface LegacyGoodRunData {
  pipettes: LoadedPipette[]
  labware: LoadedLabware[]
  modules: LoadedModule[]
+ liquids: Liquid[]
  protocolId?: string
  labwareOffsets?: LabwareOffset[]
  runTimeParameters: RunTimeParameter[]

diff --git a/app/src/organisms/InterventionModal/__fixtures__/index.ts b/app/src/organisms/InterventionModal/__fixtures__/index.ts
@@ -8,6 +8,7 @@ import {
 import type { RunData } from '@opentrons/api-client'
 import type {
  LabwareDefinitionsByUri,
+ Liquid,
  LoadedLabware,
  LoadedModule,
 } from '@opentrons/shared-data'
@@ -176,6 +177,12 @@ export const mockThermocyclerModule: LoadedModule = {
  serialNumber: 'dummySerialTC',
 }
 
+export const mockLiquid: Liquid = {
+ id: 'mockLiquid',
+ displayName: 'mock liquid',
+ description: 'this is my mock liquid description',
+}
+
 export const mockRunData: RunData = {
  id: 'mockRunData',
  createdAt: '',
@@ -188,6 +195,7 @@ export const mockRunData: RunData = {
  pipettes: [],
  labware: [mockLabwareOnModule, mockLabwareOnSlot, mockLabwareOffDeck],
  modules: [mockModule],
+ liquids: [mockLiquid],
  runTimeParameters: [],
 }
 

diff --git a/app/src/organisms/RunPreview/index.tsx b/app/src/organisms/RunPreview/index.tsx
@@ -92,6 +92,7 @@ export const RunPreviewComponent = (
  labware: runRecord.data.labware ?? [],
  modules: runRecord.data.modules ?? [],
  pipettes: runRecord.data.pipettes ?? [],
+ liquids: runRecord.data.liquids ?? [],
  commands: commands,
  }
  : robotSideAnalysis

diff --git a/app/src/organisms/RunTimeControl/__fixtures__/index.ts b/app/src/organisms/RunTimeControl/__fixtures__/index.ts
@@ -41,6 +41,7 @@ export const mockPausedRun: RunData = {
  pipettes: [],
  labware: [],
  modules: [],
+ liquids: [],
  runTimeParameters: [],
 }
 
@@ -66,6 +67,7 @@ export const mockPauseRequestedRun: RunData = {
  pipettes: [],
  labware: [],
  modules: [],
+ liquids: [],
  runTimeParameters: [],
 }
 
@@ -96,6 +98,7 @@ export const mockRunningRun: RunData = {
  pipettes: [],
  labware: [],
  modules: [],
+ liquids: [],
  runTimeParameters: [],
 }
 
@@ -136,6 +139,7 @@ export const mockFailedRun: RunData = {
  pipettes: [],
  labware: [],
  modules: [],
+ liquids: [],
  runTimeParameters: [],
 }
 
@@ -171,6 +175,7 @@ export const mockStopRequestedRun: RunData = {
  pipettes: [],
  labware: [],
  modules: [],
+ liquids: [],
  runTimeParameters: [],
 }
 
@@ -206,6 +211,7 @@ export const mockStoppedRun: RunData = {
  pipettes: [],
  labware: [],
  modules: [],
+ liquids: [],
  runTimeParameters: [],
 }
 
@@ -236,6 +242,7 @@ export const mockSucceededRun: RunData = {
  pipettes: [],
  labware: [],
  modules: [],
+ liquids: [],
  runTimeParameters: [],
 }
 
@@ -250,6 +257,7 @@ export const mockIdleUnstartedRun: RunData = {
  pipettes: [],
  labware: [],
  modules: [],
+ liquids: [],
  runTimeParameters: [],
 }
 
@@ -280,6 +288,7 @@ export const mockIdleStartedRun: RunData = {
  pipettes: [],
  labware: [],
  modules: [],
+ liquids: [],
  runTimeParameters: [],
 }
 

diff --git a/react-api-client/src/runs/__fixtures__/runs.ts b/react-api-client/src/runs/__fixtures__/runs.ts
@@ -32,6 +32,7 @@ export const mockPausedRun: RunData = {
  pipettes: [],
  labware: [],
  modules: [],
+ liquids: [],
  runTimeParameters: [],
 }
 
@@ -62,6 +63,7 @@ export const mockRunningRun: RunData = {
  pipettes: [],
  labware: [],
  modules: [],
+ liquids: [],
  runTimeParameters: [],
 }