Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(app,api,robot-server): remove old sim flag #15018

Merged
merged 6 commits into from
Apr 29, 2024
Merged

fix(app,api,robot-server): remove old sim flag #15018

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
9882a68
fix(app,api,robot-server): remove old sim flag
sfoster1 Apr 25, 2024
d37c09e
mispelling
sfoster1 Apr 25, 2024
6b05236
just remove the dang ol option
sfoster1 Apr 26, 2024
ed4bd90
one more import
sfoster1 Apr 26, 2024
a0bbfc5
couple more
sfoster1 Apr 26, 2024
a841366
dont know how i missed these
sfoster1 Apr 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
mispelling
  • Loading branch information
@sfoster1
sfoster1 committed Apr 25, 2024
commit d37c09e4dcd2c6ff7d753d63813fd5b19a031ef3
2 changes: 1 addition & 1 deletion api/src/opentrons/config/advanced_settings.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -721,7 +721,7 @@ def _migrate33to34(previous: SettingsMap) -> SettingsMap:

- Removes disableFastProtocolUpload
"""
removals = ["disableFastProtocolUploads"]
removals = ["disableFastProtocolUpload"]
newmap = {k: v for k, v in previous.items() if k not in removals}
return newmap

Expand Down
2 changes: 1 addition & 1 deletion api/tests/opentrons/config/test_advanced_settings_migration.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@

@pytest.fixture
def migrated_file_version() -> int:
return 33
return 34


# make sure to set a boolean value in default_file_settings only if
Expand Down
Loading