fix(app,api,robot-server): remove old sim flag #15018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the disableFastProtocolUpload flag. This flag makes the simulation stack, when simulating older protocols, use a hardware controller built in simulation mode and a full standard protocol context and/or engine. This is... not something we've significantly tested and has a lot of surprising problems, and at this point it doesn't bring much value. So remove the feature flag. The old behavior can still be accessed via opentrons_simulate, which will only use the simulating hardware controller when simulating pre-engine python and json protocols. Closes EXEC-360
DerekMaggio
approved these changes
Apr 26, 2024
There was a problem hiding this comment.
It makes sense to me to remove this.
If customers are relying on it because the fast protocol upload stuff fails, then we should be fixing fast protocol upload stuff, not exposing unmaintained and basically deprecated functionality.
The only caveat is, have we checked with support to see if they have an idea of if there is a large amount of customers this will cause issues for?
All the Python side of things look good to me
TamarZanzouri
approved these changes
Apr 29, 2024
SyntaxColoring
approved these changes
Apr 29, 2024
app/src/organisms/Devices/RobotSettings/AdvancedTab/UseOlderProtocol.tsx
Show resolved
Hide resolved
caila-marashaj
approved these changes
Apr 29, 2024
Carlos-fernandez
pushed a commit
that referenced
this pull request
May 20, 2024
Remove the disableFastProtocolUpload flag. This flag makes the simulation stack, when simulating older protocols, use a hardware controller built in simulation mode and a full standard protocol context and/or engine. This is... not something we've significantly tested and has a lot of surprising problems, and at this point it doesn't bring much value. So remove the feature flag. The old behavior can still be accessed via opentrons_simulate, which will only use the simulating hardware controller when simulating pre-engine python and json protocols. Closes EXEC-360
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the disableFastProtocolUpload flag.
This flag makes the simulation stack, when simulating older protocols, use a hardware controller built in simulation mode and a full standard protocol context and/or engine. This is... not something we've significantly tested and has a lot of surprising problems, and at this point it doesn't bring much value. So remove the feature flag.
The old behavior can still be accessed via opentrons_simulate, which will only use the simulating hardware controller when simulating pre-engine python and json protocols.
Closes EXEC-360
To come out of draft