Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(monorepo): update lint-js command #14977

Merged
merged 2 commits into from
Apr 25, 2024
Merged

refactor(monorepo): update lint-js command #14977

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
88b9444
refactor(monorepo): update lint-js command
koji Apr 23, 2024
e4fbb98
address feedback
koji Apr 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,3 +160,4 @@ opentrons-robot-app.tar.gz
# asdf versions file
.tool-versions
mock_dir
.eslintcache
7 changes: 4 additions & 3 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,10 +214,11 @@ lint-py: $(PYTHON_LINT_TARGETS)
%-py-lint:
$(MAKE) -C $* lint

.PHONY: lint-js
SyntaxColoring marked this conversation as resolved.
Show resolved Hide resolved
lint-js:
yarn eslint --quiet=$(quiet) ".*.@(js|ts|tsx)" "**/*.@(js|ts|tsx)"
yarn prettier --ignore-path .eslintignore --check $(FORMAT_FILE_GLOB)
@pids=""; \
yarn eslint --quiet=$(quiet) --ignore-pattern "node_modules/" --cache ".*.@(js|ts|tsx)" "**/*.@(js|ts|tsx)" & pids="$$pids $$!"; \
yarn prettier --ignore-path .eslintignore --check $(FORMAT_FILE_GLOB) & pids="$$pids $$!"; \
for pid in $$pids; do wait $$pid; done
SyntaxColoring marked this conversation as resolved.
Show resolved Hide resolved

.PHONY: lint-json
lint-json:
Expand Down
Loading