Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(monorepo): update lint-js command #14977

Merged
merged 2 commits into from
Apr 25, 2024
Merged

Conversation

koji
Copy link
Contributor

@koji koji commented Apr 23, 2024

Overview

update lint-js command to speed up the linting process

ESLint and Prettier can be run in parallel to reduce processing time. Using pid to handle commands parallelly.

Add --cache
https://eslint.org/blog/2015/09/eslint-v1.4.0-released/#cached-results

close AUTH-363

Test Plan

make lint-js

Changelog

Review requests

Risk assessment

low

update lint-js command to speed up the linting process

close AUTH-
@koji koji marked this pull request as ready for review April 23, 2024 12:14
@koji koji requested a review from a team as a code owner April 23, 2024 12:14
Copy link

codecov bot commented Apr 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.63%. Comparing base (8f50b08) to head (88b9444).
Report is 122 commits behind head on edge.

❗ Current head 88b9444 differs from pull request most recent head e4fbb98. Consider uploading reports for the commit e4fbb98 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             edge   #14977      +/-   ##
==========================================
- Coverage   67.50%   62.63%   -4.88%     
==========================================
  Files        2521      262    -2259     
  Lines       72090    14916   -57174     
  Branches     9311        0    -9311     
==========================================
- Hits        48666     9342   -39324     
+ Misses      21228     5574   -15654     
+ Partials     2196        0    -2196     
Flag Coverage Δ
api ?
app ?
components ?
g-code-testing 92.43% <ø> (ø)
hardware 55.62% <ø> (-1.92%) ⬇️
hardware-testing ?
labware-library ?
notify-server ?
ot3-gravimetric-test ?
protocol-designer ?
react-api-client ?
robot-server ?
shared-data 76.11% <ø> (+0.79%) ⬆️
step-generation ?
system-server ?
update-server 50.56% <ø> (ø)
usb-bridge 76.94% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2284 files with indirect coverage changes

Makefile Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Copy link
Contributor

@SyntaxColoring SyntaxColoring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TY!

Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a lot better for eslint (first run is like 3-5 minutes, subsequent runs are 25 seconds) - enough that prettier --check becomes the limiting factor. Let's merge this IMO

@koji koji merged commit b2644e5 into edge Apr 25, 2024
58 checks passed
Carlos-fernandez pushed a commit that referenced this pull request May 20, 2024
* refactor(monorepo): update lint-js command
@koji koji deleted the refactor_lint-js-command branch July 4, 2024 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants