Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(components): install udev before calling setup #14937

Merged
merged 1 commit into from
Apr 17, 2024

Conversation

shlokamin
Copy link
Member

@shlokamin shlokamin commented Apr 17, 2024

Overview

Follow up to #14935

This PR explicitly installs udev before calling make setup in the components CI workflow. This is required to do a full make setup because our usb bindings need it.

Hopefully closes AUTH-331 but I need to push another tag to verify

Risk assessment

Low

@shlokamin shlokamin marked this pull request as ready for review April 17, 2024 18:51
@shlokamin shlokamin requested a review from a team as a code owner April 17, 2024 18:51
@shlokamin shlokamin requested a review from y3rsh April 17, 2024 18:53
@shlokamin shlokamin changed the title ci(components): instal udev before calling setup ci(components): install udev before calling setup Apr 17, 2024
Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sigh

@shlokamin shlokamin merged commit 68aa208 into edge Apr 17, 2024
20 checks passed
@shlokamin shlokamin deleted the components-install-udev-in-workflow branch April 17, 2024 20:47
Carlos-fernandez pushed a commit that referenced this pull request May 20, 2024
# Overview

Follow up to #14935

This PR explicitly installs udev before calling make setup in the
components CI workflow. This is required to do a full make setup because
our usb bindings need it.

Hopefully closes
[AUTH-331](https://opentrons.atlassian.net/browse/AUTH-331) but I need
to push another tag to verify

# Risk assessment

Low

[AUTH-331]:
https://opentrons.atlassian.net/browse/AUTH-331?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants