ci(components): fix github deploy action #14935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
y3rsh
approved these changes
Apr 17, 2024
shlokamin
added a commit
that referenced
this pull request
Apr 17, 2024
# Overview Follow up to #14935 This PR explicitly installs udev before calling make setup in the components CI workflow. This is required to do a full make setup because our usb bindings need it. Hopefully closes [AUTH-331](https://opentrons.atlassian.net/browse/AUTH-331) but I need to push another tag to verify # Risk assessment Low [AUTH-331]: https://opentrons.atlassian.net/browse/AUTH-331?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
shlokamin
added a commit
that referenced
this pull request
Apr 22, 2024
# Overview Follow up to #14935 This PR adds make a make setup call that got deleted on accident. # Risk assessment Low
Carlos-fernandez
pushed a commit
that referenced
this pull request
May 20, 2024
Carlos-fernandez
pushed a commit
that referenced
this pull request
May 20, 2024
# Overview Follow up to #14935 This PR explicitly installs udev before calling make setup in the components CI workflow. This is required to do a full make setup because our usb bindings need it. Hopefully closes [AUTH-331](https://opentrons.atlassian.net/browse/AUTH-331) but I need to push another tag to verify # Risk assessment Low [AUTH-331]: https://opentrons.atlassian.net/browse/AUTH-331?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
Carlos-fernandez
pushed a commit
that referenced
this pull request
May 20, 2024
# Overview Follow up to #14935 This PR adds make a make setup call that got deleted on accident. # Risk assessment Low
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Somewhere in the vite migration when we got rid of yarn, adopted pnpm, then got rid of pnpm and brought back yarn we forgot to install deps for the components deploy action. This PR adds a line back to actually install deps.
closes AUTH-331
Test Plan
Changelog
Risk assessment
Low