-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(protocol-designer,shared-data,components,app): adapter split support #13237
Conversation
Codecov Report
@@ Coverage Diff @@
## chore_release-7.0.0 #13237 +/- ##
=======================================================
- Coverage 71.72% 63.77% -7.95%
=======================================================
Files 1582 1705 +123
Lines 52280 31993 -20287
Branches 3321 7739 +4418
=======================================================
- Hits 37499 20405 -17094
+ Misses 14260 9767 -4493
- Partials 521 1821 +1300
Flags with carried forward coverage won't be shown. Click here to find out more.
|
'opentrons_96_aluminumblock_biorad_wellplate_200ul', | ||
'opentrons_96_aluminumblock_nest_wellplate_100ul', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe i should filter out these old aluminum block defs more locally and not here? We basically don't want them selectable at all from the aluminumBlock
category
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is probably ok for now. As long as there's no change legacy protocols will need these definitions (assuming they get swapped out in migration)
ce760b3
to
099ef9e
Compare
Components that need test coverage from this. It will likely be completed in a follow up PR:
ticket for the follow up: https://opentrons.atlassian.net/browse/RAUT-624 |
errorToShow={ | ||
!props.canSave && bothFieldsSelected | ||
? i18n.t( | ||
'form.step_edit_form.labwareLabel.errors.labwareSlotIncompatible' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will specify the labware and the new location in this string in a follow up ticket as well as specifying the adapter name in the dropdown.
65ad726
to
8020179
Compare
Follow up work post merge:
|
protocol-designer/src/components/steplist/MoveLabwareHeader.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🌐
closes RAUT-609 and RAUT-612
closes RAUT-561 and RQA-1076 and RQA-1114
Overview
Adapter Split work in PD and App
Note: I will add more test coverage in a follow up pr
Test Plan
For Pd:
sandbox: https://sandbox.designer.opentrons.com/pd_adapter-split/
loadLabware
commandsmoveLabware
form, move labware on/off the adapters and modules and make sure it properly errors if you try to move a labware onto an adapter/module that doesn't work with that labware. Also make sure themovelabware
form allows you to select tipracks and not select the trash.For the app:
Changelog
PD:
7_0_0
migration and thefileCreator
to accommodate load adapterShared-data:
NonStackedLabware
and extended theLabwareLocation
type to includelabwareId
.App:
labwareId
which included all the deck map renders in the app and odd (deckThumbnail, protocol setup, odd protocol setup) and the command text.Review requests
see test plan
Risk assessment
low