feat(protocol-designer): allow tip racks but not trash selection in moveLabware form #13109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerader
changed the title
Codecov Report
@@ Coverage Diff @@
## edge #13109 +/- ##
=======================================
Coverage 72.45% 72.45%
=======================================
Files 2388 2388
Lines 65998 66001 +3
Branches 7306 7308 +2
=======================================
+ Hits 47817 47820 +3
Misses 16442 16442
Partials 1739 1739
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
i ended up making this change in this pr: #13237 so gonna close this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes RAUT-561 and RQA-1076 and RQA-1114
Overview
When you move a labware, tip racks on the deck are now selectable but the trash is no longer selectable (for now since only a fixed trash is supported)
Test Plan
sandbox: https://sandbox.designer.opentrons.com/pd_labware-dropdown-options/
add a move labware step in the timeline, doesn't matter which robot type it is. The tipracks on the deck should be selectable but the trash should not be selectable in the drop down.
add a transfer or mix to the timeline. The labware selection should not show tip racks but should show the trash.
Changelog
getLabwareOptionsselector and test to have branching logic for tipracks and trash when the presaved step ismoveLabwareReview requests
see test plan
Risk assessment
low