Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api): change slots used to calibrate belts #12771

Merged
merged 1 commit into from
May 23, 2023

Conversation

pmoegenburg
Copy link
Member

@pmoegenburg pmoegenburg commented May 23, 2023

Overview

Currently, we use deck slots 12, 3, and 10 to calibrate the x and y gantry belts. With 12 being the designated garbage slot, it would be more user-friendly to not use this slot. The same calibration results (attitude matrix with same orientation) can be achieved using deck slots 1, 10, and 3.

Test Plan

Below are the belt calibration results achieved using these two sets of deck slots. The calibrate_belts api method was used.

Slots (12, 3, 10) Belt Calibration Attitude Matrix:
[[0.9979, -0.0001, 0.0], [0.0007, 0.9984, 0.0], [0.0, 0.0, 1.0]]

Slots (1, 10, 3) Belt Calibration Attitude Matrix:
[[0.9983, -0.0, 0.0], [0.0007, 0.9985, 0.0], [0.0, 0.0, 1.0]]

Changelog

Review requests

Risk assessment

@pmoegenburg pmoegenburg requested a review from a team as a code owner May 23, 2023 19:00
@pmoegenburg pmoegenburg self-assigned this May 23, 2023
@pmoegenburg pmoegenburg requested a review from sfoster1 May 23, 2023 19:01
Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a good idea but please put a more in-depth description in the PR description and eventual commit message.

@codecov
Copy link

codecov bot commented May 23, 2023

Codecov Report

Merging #12771 (1a5dfb1) into edge (5758bf4) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             edge   #12771   +/-   ##
=======================================
  Coverage   73.36%   73.36%           
=======================================
  Files        2294     2294           
  Lines       62994    62994           
  Branches     6847     6847           
=======================================
  Hits        46217    46217           
  Misses      15159    15159           
  Partials     1618     1618           
Flag Coverage Δ
g-code-testing 96.44% <ø> (ø)
notify-server 89.13% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@pmoegenburg pmoegenburg changed the title fix(api): change belt calibration slots so garbage doesn't have to be moved fix(api): change slots used to calibrate belts May 23, 2023
@pmoegenburg pmoegenburg merged commit f064b10 into edge May 23, 2023
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants