Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(app): export internal components in RobotSettingsDashboard #12681

Merged
merged 4 commits into from
May 11, 2023

Conversation

koji
Copy link
Contributor

@koji koji commented May 10, 2023

Overview

Current RobotSettingsDashboard is more than 400 lines and that makes a little bit difficult to add a new setting to the RobotSettingsDashboard. This PR exports two internal components in RobotSettingsDashboard.

The layout fix PR is in internal_release_0.7.0, so RobotSettings' each setting screen layout issue will be solved when it merge into the edge.

Tests will be updated in a following PR.

Test Plan

Changelog

  • export RobotSettingButton
  • export SettingsContent as RobotSettingsContent

Review requests

Risk assessment

low

koji added 4 commits May 9, 2023 23:17
update led lights button in robot settings, add tests, and remove dummy components
Make RobotSettingButton into component to make RobotSettingsDashboard more maintainable
@codecov
Copy link

codecov bot commented May 10, 2023

Codecov Report

Merging #12681 (2455a96) into edge (761e30d) will decrease coverage by 0.01%.
The diff coverage is 80.95%.

Impacted file tree graph

@@            Coverage Diff             @@
##             edge   #12681      +/-   ##
==========================================
- Coverage   73.54%   73.53%   -0.01%     
==========================================
  Files        2275     2277       +2     
  Lines       62635    62633       -2     
  Branches     6699     6699              
==========================================
- Hits        46062    46060       -2     
  Misses      14972    14972              
  Partials     1601     1601              
Flag Coverage Δ
app 72.07% <80.95%> (-0.01%) ⬇️
protocol-designer 46.34% <ø> (ø)
step-generation 88.20% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...viceDisplay/RobotSettingsDashboard/DeviceReset.tsx 83.87% <ø> (ø)
...ay/RobotSettingsDashboard/EnableDeveloperTools.tsx 0.00% <ø> (ø)
...y/RobotSettingsDashboard/NetworkSettings/index.tsx 83.33% <ø> (ø)
...DeviceDisplay/RobotSettingsDashboard/RobotName.tsx 66.66% <ø> (ø)
...play/RobotSettingsDashboard/RobotSystemVersion.tsx 91.66% <ø> (ø)
...nDeviceDisplay/RobotSettingsDashboard/TextSize.tsx 62.50% <ø> (ø)
...isplay/RobotSettingsDashboard/TouchScreenSleep.tsx 90.00% <ø> (ø)
...y/RobotSettingsDashboard/TouchscreenBrightness.tsx 100.00% <ø> (ø)
...ceDisplay/RobotSettingsDashboard/UpdateChannel.tsx 82.35% <ø> (ø)
...s/OnDeviceDisplay/RobotSettingsDashboard/index.tsx 73.33% <73.33%> (ø)
... and 2 more

... and 2 files with indirect coverage changes

@koji koji marked this pull request as ready for review May 10, 2023 22:40
@koji koji requested a review from a team as a code owner May 10, 2023 22:40
@koji koji removed the request for review from a team May 10, 2023 22:40
@koji koji merged commit b84734e into edge May 11, 2023
30 of 31 checks passed
@koji koji deleted the refactor-RobotSettingsDashboard-button-component branch June 17, 2023 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants