refactor(app): export internal components in RobotSettingsDashboard (#…

…12681) Make RobotSettingButton & SettingsConten into an external component
Opentrons · May 11, 2023 · b84734e · b84734e
1 parent 761e30d
commit b84734e
Show file tree

Hide file tree

Showing 14 changed files with 444 additions and 434 deletions.
diff --git a/app/src/organisms/OnDeviceDisplay/RobotSettingsDashboard/DeviceReset.tsx b/app/src/organisms/OnDeviceDisplay/RobotSettingsDashboard/DeviceReset.tsx
@@ -28,7 +28,7 @@ import { useDispatchApiRequest } from '../../../redux/robot-api'
 
 import type { Dispatch, State } from '../../../redux/types'
 import type { ResetConfigRequest } from '../../../redux/robot-admin/types'
-import type { SettingOption } from '../../../pages/OnDeviceDisplay/RobotSettingsDashboard'
+import type { SettingOption } from '../../../pages/OnDeviceDisplay/RobotSettingsDashboard/RobotSettingButton'
 
 interface LabelProps {
  isSelected?: boolean

diff --git a/app/src/organisms/OnDeviceDisplay/RobotSettingsDashboard/EnableDeveloperTools.tsx b/app/src/organisms/OnDeviceDisplay/RobotSettingsDashboard/EnableDeveloperTools.tsx
@@ -11,7 +11,7 @@ import {
 
 import { StyledText } from '../../../atoms/text'
 
-import type { SettingOption } from '../../../pages/OnDeviceDisplay/RobotSettingsDashboard'
+import type { SettingOption } from '../../../pages/OnDeviceDisplay/RobotSettingsDashboard/RobotSettingButton'
 
 interface EnableDeveloperToolsProps {
  setCurrentOption: (currentOption: SettingOption | null) => void

diff --git a/app/src/organisms/OnDeviceDisplay/RobotSettingsDashboard/NetworkSettings/index.tsx b/app/src/organisms/OnDeviceDisplay/RobotSettingsDashboard/NetworkSettings/index.tsx
@@ -26,7 +26,7 @@ import { WifiConnectionDetails } from './WifiConnectionDetails'
 import type { IconName } from '@opentrons/components'
 import type { NetworkConnection } from '../../../../pages/OnDeviceDisplay/hooks'
 import type { ChipType } from '../../../../atoms/Chip'
-import type { SettingOption } from '../../../../pages/OnDeviceDisplay/RobotSettingsDashboard'
+import type { SettingOption } from '../../../../pages/OnDeviceDisplay/RobotSettingsDashboard/RobotSettingButton'
 
 export type ConnectionType = 'wifi' | 'ethernet' // TODO (kj: 04/05/2023) add 'usb' as options once implemented
 

diff --git a/app/src/organisms/OnDeviceDisplay/RobotSettingsDashboard/RobotName.tsx b/app/src/organisms/OnDeviceDisplay/RobotSettingsDashboard/RobotName.tsx
@@ -11,7 +11,7 @@ import {
 
 import { StyledText } from '../../../atoms/text'
 
-import type { SettingOption } from '../../../pages/OnDeviceDisplay/RobotSettingsDashboard'
+import type { SettingOption } from '../../../pages/OnDeviceDisplay/RobotSettingsDashboard/RobotSettingButton'
 
 interface RobotNameProps {
  setCurrentOption: (currentOption: SettingOption | null) => void

diff --git a/app/src/organisms/OnDeviceDisplay/RobotSettingsDashboard/RobotSystemVersion.tsx b/app/src/organisms/OnDeviceDisplay/RobotSettingsDashboard/RobotSystemVersion.tsx
@@ -22,7 +22,7 @@ import { StyledText } from '../../../atoms/text'
 import { RobotSystemVersionModal } from './RobotSystemVersionModal'
 import { getShellUpdateState } from '../../../redux/shell'
 
-import type { SettingOption } from '../../../pages/OnDeviceDisplay/RobotSettingsDashboard'
+import type { SettingOption } from '../../../pages/OnDeviceDisplay/RobotSettingsDashboard/RobotSettingButton'
 
 const GITHUB_URL = 'https://github.com/Opentrons/opentrons'
 

diff --git a/app/src/organisms/OnDeviceDisplay/RobotSettingsDashboard/TextSize.tsx b/app/src/organisms/OnDeviceDisplay/RobotSettingsDashboard/TextSize.tsx
@@ -19,7 +19,7 @@ import {
 
 import { StyledText } from '../../../atoms/text'
 
-import type { SettingOption } from '../../../pages/OnDeviceDisplay/RobotSettingsDashboard'
+import type { SettingOption } from '../../../pages/OnDeviceDisplay/RobotSettingsDashboard/RobotSettingButton'
 
 interface RectProps {
  isActive: boolean

diff --git a/app/src/organisms/OnDeviceDisplay/RobotSettingsDashboard/TouchScreenSleep.tsx b/app/src/organisms/OnDeviceDisplay/RobotSettingsDashboard/TouchScreenSleep.tsx
@@ -20,7 +20,7 @@ import {
 import { SLEEP_NEVER_MS } from '../../../App/constants'
 
 import type { Dispatch } from '../../../redux/types'
-import type { SettingOption } from '../../../pages/OnDeviceDisplay/RobotSettingsDashboard'
+import type { SettingOption } from '../../../pages/OnDeviceDisplay/RobotSettingsDashboard/RobotSettingButton'
 
 const SLEEP_TIME_MS = 60 * 1000 // 1 min
 

diff --git a/app/src/organisms/OnDeviceDisplay/RobotSettingsDashboard/TouchscreenBrightness.tsx b/app/src/organisms/OnDeviceDisplay/RobotSettingsDashboard/TouchscreenBrightness.tsx
@@ -27,7 +27,7 @@ import {
 } from '../../../redux/config'
 
 import type { Dispatch } from '../../../redux/types'
-import type { SettingOption } from '../../../pages/OnDeviceDisplay/RobotSettingsDashboard'
+import type { SettingOption } from '../../../pages/OnDeviceDisplay/RobotSettingsDashboard/RobotSettingButton'
 
 const BUTTON_STYLE = css`
  &:focus-visible {

diff --git a/app/src/organisms/OnDeviceDisplay/RobotSettingsDashboard/UpdateChannel.tsx b/app/src/organisms/OnDeviceDisplay/RobotSettingsDashboard/UpdateChannel.tsx
@@ -23,7 +23,7 @@ import {
 } from '../../../redux/config'
 
 import type { Dispatch } from '../../../redux/types'
-import type { SettingOption } from '../../../pages/OnDeviceDisplay/RobotSettingsDashboard'
+import type { SettingOption } from '../../../pages/OnDeviceDisplay/RobotSettingsDashboard/RobotSettingButton'
 
 interface LabelProps {
  isSelected?: boolean