-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(odd): single mount and 96-channel pipette flows (attach, detach, cal) #12210
Conversation
Codecov Report
@@ Coverage Diff @@
## edge #12210 +/- ##
==========================================
- Coverage 74.28% 73.70% -0.59%
==========================================
Files 2161 2210 +49
Lines 59715 61020 +1305
Branches 6105 6299 +194
==========================================
+ Hits 44361 44974 +613
- Misses 13924 14590 +666
- Partials 1430 1456 +26
Flags with carried forward coverage won't be shown. Click here to find out more.
|
3e1ccf8
to
f73c1cf
Compare
4763730
to
f34e108
Compare
518dab6
to
28bfcb3
Compare
Default.args = { | ||
onClick: () => console.log('click'), | ||
buttonType: 'default', | ||
buttonText: 'text', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we use Button text
to align with the DS?
b53bd66
to
7d76618
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, just one comment/question! I put this on an ODD yesterday and the screens look good. I wasn't able to test the functionality all the way through without better ODD logging, so I'll make a follow-on ticket to test these flows on ODD once logging is improved. Great work 🤩
</PrimaryButton> | ||
isOnDevice ? ( | ||
<SmallButton | ||
onClick={proceed} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason why this onClick is different from the primary button below?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oops ya this should be handleCheckZAxis
! good catch. I'll fix it now :D
closes RLIQ-229, RLIQ-230, RLIQ-234, RLIQ-231, RLIQ-232, RLIQ-233, RLIQ-341, RAUT-352
Overview
Adds ODD ui for attach, (re)calibrate, and detach flows for the single mount pipettes and 96-channel pipette.
Test Plan
Changelog
GenericWizardTile
,SimpleWizardBody
,InProgressModal
, andBanner
to accommodate the ODD uiSmallButton
, create story and test to accommodate all 6 optionsPipetteWizardFlows
to match designsSmallButton
is so intricate compared to the other buttonsReview requests
(pointer: coarse)
work on the ODD for the media query?Risk assessment
low