Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(hardware): add progress output to subsystem firmware update process #12059

Merged
merged 11 commits into from
Feb 9, 2023
Merged

feat(hardware): add progress output to subsystem firmware update process #12059

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
5def3f6
refactor(hardware): make RunUpdate a class
pmoegenburg Jan 25, 2023
adb010b
Merge branch 'edge' into RCORE-473_add_progress_output_to_multiple_up…
pmoegenburg Jan 25, 2023
4d46104
feat(hardware): added progress reporting object and refactored to que…
pmoegenburg Feb 7, 2023
bc5d463
fix(hardware): fixed task aggregation and test
pmoegenburg Feb 7, 2023
d0ea427
Merge branch 'edge' into RCORE-473_add_progress_output_to_multiple_up…
pmoegenburg Feb 8, 2023
9ab01f5
fix(hardware, api): properly work with AsyncIterator method output an…
pmoegenburg Feb 8, 2023
a4e4326
feat(hardware): updated update_fws to take a json dict of nodes and f…
pmoegenburg Feb 8, 2023
01cf398
fix(hardware): properly load json file into dict for unpacking
pmoegenburg Feb 8, 2023
2892283
fix(hardware): properly assign node_id from json to NodeId element
pmoegenburg Feb 8, 2023
da978ed
fix(hardware): linted
pmoegenburg Feb 8, 2023
4de20d8
script takes ios not paths
sfoster1 Feb 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix(hardware): fixed task aggregation and test
  • Loading branch information
@pmoegenburg
pmoegenburg committed Feb 7, 2023
commit bc5d463450087a36721593565e88c85f31865a6d
2 changes: 1 addition & 1 deletion hardware/opentrons_hardware/firmware_update/run.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ async def run_updates(
for node_id, hex_file in self._update_details.items()
]

task = asyncio.create_task(asyncio.gather(*tasks))
task = asyncio.gather(*tasks)
while True:
try:
yield await asyncio.wait_for(self._status_queue.get(), 0.25)
Expand Down
2 changes: 2 additions & 0 deletions hardware/tests/opentrons_hardware/firmware_update/test_run.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,11 +158,13 @@ async def test_run_updates(
hex_processor=mock_hex_record_processor,
ack_wait_seconds=11,
),
mock.call().__aiter__(),
mock.call(
node_id=target_2.bootloader_node,
hex_processor=mock_hex_record_processor,
ack_wait_seconds=11,
),
mock.call().__aiter__(),
]
)

Expand Down