Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(robot-server): fully delete current run #11070

Merged
merged 3 commits into from
Jul 11, 2022
Merged

fix(robot-server): fully delete current run #11070

merged 3 commits into from
Jul 11, 2022

Conversation

jbleon95
Copy link
Contributor

Overview

Closes #10909

Addresses bug where deleting a current run would only remove it from the engine_store but not the run_store, resulting the run still existing in memory.

Changelog

  • Fixed bug where current runs were not deleted from run_store
  • Added simple tavern test for deleting a current run

Review requests

Risk assessment

Low

@jbleon95 jbleon95 added the robot-svcs Falls under the purview of the Robot Services squad (formerly CPX, Core Platform Experience). label Jul 11, 2022
@jbleon95 jbleon95 requested review from a team as code owners July 11, 2022 14:33
mcous
mcous approved these changes Jul 11, 2022
View reviewed changes
Copy link
Contributor

@mcous mcous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, thanks for adding the acceptance test

robot-server/tests/runs/test_run_data_manager.py Outdated Show resolved Hide resolved
@jbleon95 jbleon95 merged commit da45a96 into edge Jul 11, 2022
@SyntaxColoring SyntaxColoring deleted the robot-server-delete-run-bug branch July 12, 2022 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcous mcous mcous approved these changes

Assignees
No one assigned
Labels
robot-svcs Falls under the purview of the Robot Services squad (formerly CPX, Core Platform Experience).
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: DELETEing the current run only marks it as not current without deleting it
2 participants
@jbleon95 @mcous