Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: DELETEing the current run only marks it as not current without deleting it #10909

Closed
SyntaxColoring opened this issue Jun 24, 2022 · 0 comments · Fixed by #11070
Closed
Assignees
Labels
bug robot server Affects the `robot-server` project robot-svcs Falls under the purview of the Robot Services squad (formerly CPX, Core Platform Experience).

Comments

@SyntaxColoring
Copy link
Contributor

Overview

DELETEing a run over HTTP seems to only actually delete it if it isn't the current run. If it is the current run, the DELETE merely marks it as not current, without actually deleting it.

Steps to reproduce

  1. POST a run over HTTP with POST /runs {"data": {}}.
  2. GET the run with GET /runs/{id} and see that it's "current": true.
  3. DELETE the run with DELETE /runs/{id}. You'll get an empty {} response back with an HTTP 200 code.
  4. GET the run again. It will still be there, but now it will be "current": false.
    • Expected: This should be a 404 error.
  5. DELETE the run a second time. You'll get the same empty {} response with an HTTP 200 code.
  6. GET the run again. Now it will be a 404 error, as expected.
@SyntaxColoring SyntaxColoring added bug robot-svcs Falls under the purview of the Robot Services squad (formerly CPX, Core Platform Experience). robot server Affects the `robot-server` project labels Jun 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug robot server Affects the `robot-server` project robot-svcs Falls under the purview of the Robot Services squad (formerly CPX, Core Platform Experience).
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants