Skip to content

Commit

Permalink
fix(api): retract function should acquire motion lock (#14944)
Browse files Browse the repository at this point in the history
<!--
Thanks for taking the time to open a pull request! Please make sure
you've read the "Opening Pull Requests" section of our Contributing
Guide:


https://github.com/Opentrons/opentrons/blob/edge/CONTRIBUTING.md#opening-pull-requests

To ensure your code is reviewed quickly and thoroughly, please fill out
the sections below to the best of your ability!
-->

# Overview
This PR wraps the hardware controller retract function in the motion
lock.

<!--
Use this section to describe your pull-request at a high level. If the
PR addresses any open issues, please tag the issues here.
-->

# Test Plan

<!--
Use this section to describe the steps that you took to test your Pull
Request.
If you did not perform any testing provide justification why.

OT-3 Developers: You should default to testing on actual physical
hardware.
Once again, if you did not perform testing against hardware, justify
why.

Note: It can be helpful to write a test plan before doing development

Example Test Plan (HTTP API Change)

- Verified that new optional argument `dance-party` causes the robot to
flash its lights, move the pipettes,
then home.
- Verified that when you omit the `dance-party` option the robot homes
normally
- Added protocol that uses `dance-party` argument to G-Code Testing
Suite
- Ran protocol that did not use `dance-party` argument and everything
was successful
- Added unit tests to validate that changes to pydantic model are
correct

-->

# Changelog

<!--
List out the changes to the code in this PR. Please try your best to
categorize your changes and describe what has changed and why.

Example changelog:
- Fixed app crash when trying to calibrate an illegal pipette
- Added state to API to track pipette usage
- Updated API docs to mention only two pipettes are supported

IMPORTANT: MAKE SURE ANY BREAKING CHANGES ARE PROPERLY COMMUNICATED
-->

# Review requests

<!--
Describe any requests for your reviewers here.
-->

# Risk assessment

<!--
Carefully go over your pull request and look at the other parts of the
codebase it may affect. Look for the possibility, even if you think it's
small, that your change may affect some other part of the system - for
instance, changing return tip behavior in protocol may also change the
behavior of labware calibration.

Identify the other parts of the system your codebase may affect, so that
in addition to your own review and testing, other people who may not
have the system internalized as much as you can focus their attention
and testing there.
-->
  • Loading branch information
ahiuchingau authored Apr 18, 2024
1 parent 7d6100d commit 58973c6
Showing 1 changed file with 11 additions and 10 deletions.
21 changes: 11 additions & 10 deletions api/src/opentrons/hardware_control/ot3api.py
Original file line number Diff line number Diff line change
Expand Up @@ -1655,16 +1655,17 @@ async def retract_axis(self, axis: Axis) -> None:
motor_ok = self._backend.check_motor_status([axis])
encoder_ok = self._backend.check_encoder_status([axis])

if motor_ok and encoder_ok:
# we can move to the home position without checking the limit switch
origin = await self._backend.update_position()
target_pos = {axis: self._backend.home_position()[axis]}
await self._backend.move(origin, target_pos, 400, HWStopCondition.none)
else:
# home the axis
await self._home_axis(axis)
await self._cache_current_position()
await self._cache_encoder_position()
async with self._motion_lock:
if motor_ok and encoder_ok:
# we can move to the home position without checking the limit switch
origin = await self._backend.update_position()
target_pos = {axis: self._backend.home_position()[axis]}
await self._backend.move(origin, target_pos, 400, HWStopCondition.none)
else:
# home the axis
await self._home_axis(axis)
await self._cache_current_position()
await self._cache_encoder_position()

# Gantry/frame (i.e. not pipette) config API
@property
Expand Down

0 comments on commit 58973c6

Please sign in to comment.