pkcs15-init,pkcs15-tool: reword --no-prompt to --use-pinpad (close #944) #957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nunojpg
force-pushed
the
pkcs15-tool-use-pinpad-rename
branch
from
1339af1
to
b18799e
Compare
frankmorgner
requested changes
Jan 31, 2017
| @@ -201,7 +202,8 @@ const struct option options[] = { | |||
| { "insecure", no_argument, NULL, OPT_INSECURE }, | |||
| { "use-default-transport-keys", | |||
| no_argument, NULL, 'T' }, | |||
| { "no-prompt", no_argument, NULL, OPT_NO_PROMPT }, | |||
| { "use-pinpad", no_argument, NULL, OPT_USE_PINPAD }, | |||
| { "no-prompt", no_argument, NULL, OPT_USE_PINPAD_DEPRECATED }, | |||
There was a problem hiding this comment.
Please make it a silent option or simply remove the old option.
There was a problem hiding this comment.
Yes, also thought it was the better. Just didn't find any example of a silent option, in this code. Can you point me how to do it?
There was a problem hiding this comment.
owh, I found, if the help is string (const char*) NULL it becomes silent. Will fix it. Thanks.
|
AFAIK this option was not documented at all under doc/tools (I checked it.) |
nunojpg
force-pushed
the
pkcs15-tool-use-pinpad-rename
branch
from
b18799e
to
98c73a8
Compare
|
@frankmorgner updated as advised. |
frankmorgner
requested changes
Feb 1, 2017
src/tools/pkcs15-init.c
Outdated
| case OPT_NO_PROMPT: | ||
| opt_no_prompt = 1; | ||
| case OPT_USE_PINPAD_DEPRECATED: | ||
| fprintf(stderr, "--no-prompt have been deprecated and will be removed. Use instead '--use-pinpad'.\n"); |
There was a problem hiding this comment.
Please change the messages to "'--no-prompt' is deprecated , use '--use-pinpad' instead.\n
nunojpg
force-pushed
the
pkcs15-tool-use-pinpad-rename
branch
from
98c73a8
to
beda702
Compare
…enSC#944) Wording was confusing for a novice user. Old option is mantained as an alias, but will print to stderr a deprecation warning. Deprecation related code is all marked with deprecated word to easy future removal. Signed-off-by: Nuno Goncalves <[email protected]>
Signed-off-by: Nuno Goncalves <[email protected]>
nunojpg
force-pushed
the
pkcs15-tool-use-pinpad-rename
branch
from
beda702
to
c4b7a7e
Compare
|
@frankmorgner updated. |
|
good work, thanks! |
frankmorgner
approved these changes
Feb 3, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wording was confusing for a novice user. Old option is mantained as an alias,
but will print to stderr a deprecation warning.
Deprecation related code is all marked with deprecated word to easy future removal.
Signed-off-by: Nuno Goncalves [email protected]