pkcs15-tool "--no-prompt" option rewording to "--use-pinpad"

[nunojpg]

Would like comments to reword the "--no-prompt" to "--use-pinpad".

--no-prompt looks a terrible wording for this, and it hides the fact that a pinpad is not used by default.

Will provide a pull request according to feedback.

[nunojpg]

Under stability assurance the --no-prompt would have to be kept as an alias, possibly with a "deprecation" message for at least a full release.

[nunojpg]

I would also ask comments if pkcs15-tool (which does NOT use pinpad by default), and pkcs11-tool (which does use pinpad by default), should not be aligned...

[martinpaljak]

It would be nice. I also find the "no prompt" a bit misleading.

On Thu, 26 Jan 2017, 17:25 Nuno Goncalves, ***@***.***> wrote: I would also ask comments if pkcs15-tool (which does NOT use pinpad by default), and pkcs11-tool (which does use pinpad by default), should not be aligned... — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#944 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AACztq5CUVdt-6BfxGtO1i1oJTSGdz88ks5rWMjhgaJpZM4Lqame> .

-- typos expected due to mobile device

[frankmorgner]

pkcs15-tool should only use the PIN pad if requested by the user. Look at it as low level tool.

[dengert]

Is there any sc_pkcs15_* routine to query if the reader is a pin pad reader?
That might be the missing piece, the pkcs15-tool can not tell if its a pin pad reader.
In that case the prompt would be "Use PIN PAD"

I understand that there are some pin pad readers that will not pass from the host a verify with a pin to the card, where others will. But I would expect if the card was inserted into a pin pad reader, the user, or the employer policy expects the user to use the pin pad.

[frankmorgner]

The reader handle has a flag about the pin pad capability. However, I still don't want to let pkcs15-tool apply any magic.

[frankmorgner]

I understand that there are some pin pad readers that will not pass from the host a verify with a pin to the card, where others will. But I would expect if the card was inserted into a pin pad reader, the user, or the employer policy expects the user to use the pin pad.

Indeed, both variants of readers exist. When calling pkcs15-tool the user should decide whether he wants to enter the PIN in software or on the PIN pad. That's why I'm opting for using the command line prompt as default.

[nunojpg]

@frankmorgner I understand that you don't want to align the pkcs11-tool and pkcs15-tool regarding pinpad use by default.

Regarding the wording, could you confirm if you agree it is a good idea to change it to --use-pinpad? I mean, can you make a final decision about this and close the issue?

If you agree on it I will pull request the change.

[frankmorgner]

Sure, good idea. Above, I gave my 👍 long ago...