Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support ORCID member API for authentication #2728

Merged
merged 9 commits into from
Jul 10, 2024
Merged

Support ORCID member API for authentication #2728

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
b1bd09f
feat(server): Request /read-limited ORCID scope
nellh Dec 6, 2022
f12141f
deps(server): Update passport-orcid
nellh May 7, 2024
1142000
fix(server): Improve ORCID error messages to represent the real requi…
nellh Dec 6, 2022
aaefebc
doc: Add ORCID sandbox API to default dev configuration
nellh Dec 6, 2022
e98f127
feat: Allow ORCID users with limited profile information
nellh May 22, 2024
d1ec513
feat(app): Detect ORCID sandbox API when linking to profiles
nellh Jul 8, 2024
c11a688
tests(app): Update tests for ORCID comments
nellh Jul 8, 2024
4e71d15
fix(worker): Guard against missing email in commit log generation
nellh Jul 9, 2024
33f9ebe
fix(worker): Prevent access to undefined author variable
nellh Jul 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix(worker): Prevent access to undefined author variable
  • Loading branch information
@nellh
nellh committed Jul 9, 2024
commit 33f9ebef8b44566367bb95f8186d85c0142f7b48
4 changes: 3 additions & 1 deletion services/datalad/datalad_service/handlers/upload.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,11 @@
os.path.join(dataset_path, os.path.relpath(filename, start=upload_path)))]
gevent.sleep()
move_files(upload_path, dataset_path)
if name and email:
author = pygit2.Signature(name, email)
hexsha = git_commit(repo, unlock_files, author).hex
hexsha = git_commit(repo, unlock_files, author).hex

Check warning on line 34 in services/datalad/datalad_service/handlers/upload.py

View check run for this annotation

Codecov / codecov/patch

services/datalad/datalad_service/handlers/upload.py#L32-L34 

Added lines #L32 - L34 were not covered by tests
else:
hexsha = git_commit(repo, unlock_files).hex

Check warning on line 36 in services/datalad/datalad_service/handlers/upload.py

View check run for this annotation

Codecov / codecov/patch

services/datalad/datalad_service/handlers/upload.py#L36 

Added line #L36 was not covered by tests
update_head(dataset_id, dataset_path, hexsha, cookies)


Expand Down
Loading