Support ORCID member API for authentication #2728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is deployed on staging at the moment, so it can be tested with a sandbox.orcid.org account (you must verify the mailinator address to test). |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2728 +/- ##
==========================================
+ Coverage 42.36% 42.62% +0.26%
==========================================
Files 595 592 -3
Lines 37919 37857 -62
Branches 1096 1098 +2
==========================================
+ Hits 16063 16137 +74
+ Misses 21644 21513 -131
+ Partials 212 207 -5 ☔ View full report in Codecov by Sentry. |
|
Successfully logged in: |
|
Thanks for testing @effigies, I'm going to hold off on merging this until I have the production deployment time scheduled with ORCID. |
|
Some screenshots for making a doc we can point people to:
|
…rements Error messages encourage users to use the less public "trusted institutions" settings for OpenNeuro's required fields.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This now only requires a user to make the ORCID fields available to trusted institutions. Error messages are improved to not encourage users to make these fields public unnecessarily.
Fixes #2660