F/sea state+ #970
Closed
F/sea state+ #970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move location of files which used in the new SeaState module
Added SeaState Module. This includes a new SeaState input file and a stand alone SeasState driver program. SeaState encompasses the Current, Waves, UserWaves, and Waves2 modules, and a new interpolation module. The wave kinematics are now defined on a 3D grid and the physics modules obtain kinematics for any point by interpolating the grid data.
… f/HD_InputFileParsing
Added ExctnDisp support for WAMIT bodies Added WaveDisp support for Morison members Various bug fixes Changed SeaState abbrv. to SeaSt in registry
This feature is currently unused. It will be fully implemented when ExctnDisp = 2 is implemented.
Comments make clear that the time signal is wrapped back into the valid time range [0,WaveTmax]
Trying to resolve seastate references in hydrodyn
Needed to cast reals to correct types Added SeaState_input.f90 to CmakeLists.txt
HD_Types -- some registry file dependencies not used now FAST_Types -- some registry file dependencies not used now SeaState_Types -- -noextrap flag Waves_Types -- -noextrap flag Waves2_Types -- -noextrap flag
Updates so it compiles on Ubuntu 20.04 in debug / single prec
WaveElev.out was not reporting the correct min/max values
…NY input file param
The wrapping of the time signal back into the range [0,WaveTMax] had bugs
* Removed requirement for WaveMod = 6 to have WaveDT = Driver DT * If WaveMod /= 6 and the WvKinFile is not the empty string, will cause SeaState module to write the kinematics files. * Fixed generation of SeaState summary file when WaveMod = 6 * Fixed setting wave time data range to NStepWave+1 for the Interpolation algorithm * Finished WaveMod = 6 implementation
This is more consistent with what is passed into HD and SeaState
* Added input setting in Stand-alone SeaState module driver: WrWvKinMod
0: do not write kinematics
1: write only the (0,0) WaveElevation time series
2: write all kinematics
* Changed kinematics writing to write the NStepWave increment (instead of stopping at NStepWave-1)
* Fixed kinematics reading to match above condition
* Remove completed TODO comments and removed other unnecessary commented out code
seastate: change WtrDpth to ReKi so double precision will compile
8 tasks
| real(ReKi) :: positionXY(2) | ||
|
|
||
| real(SiKi) :: GetWaveElevation(p%NBody) | ||
| TYPE(SS_Exc_InputType) :: u_out ! extra_interp result |
There was a problem hiding this comment.
Hi,
The 2-dimensional allocatable variable PtfmPos of u_out may need to be allocated here.
Best regards,
Chen
There was a problem hiding this comment.
See fix in bjonkman@1452337 (which also fixes a few other issues with this subroutine)
|
Closing this as PR #1008 supercedes it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull request is NOT ready for merging
r-test files need to be updated for new input files and input file changes
Limited testing has been performed and looks good.
Testing database is here: https://github.com/HaymanConsulting/seast-test
Feature or improvement description
Related issue, if one exists
#847
#844
#842
Impacted areas of the software
Additional supporting information
Test results, if applicable
Task list
hd_c_libinterface module