Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tuxedo-drivers: 3.2.14 -> 4.5.0 #316708

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
nixos/tuxedo-drivers: rename from tuxedo-keyboard
  • Loading branch information
MinerSebas committed Jun 2, 2024
commit b8ef83fc0c4ac28abb54a800eda03d17a36e4d9b
23 changes: 23 additions & 0 deletions nixos/modules/hardware/tuxedo-drivers.nix
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
{ config, lib, ... }:

with lib;

let
cfg = config.hardware.tuxedo-drivers;
tuxedo-drivers = config.boot.kernelPackages.tuxedo-drivers;
in
{
imports = [
(mkRenamedOptionModule ["hardware" "tuxedo-keyboard" ] ["hardware" "tuxedo-drivers" ])
];

options.hardware.tuxedo-drivers = {
enable = mkEnableOption "the drivers for TUXEDO Computers laptops.";
};

config = mkIf cfg.enable
{
boot.kernelModules = ["tuxedo_keyboard"];
boot.extraModulePackages = [ tuxedo-drivers ];
};
}
35 changes: 0 additions & 35 deletions nixos/modules/hardware/tuxedo-keyboard.nix

This file was deleted.

2 changes: 1 addition & 1 deletion nixos/modules/module-list.nix
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@
./hardware/sensor/iio.nix
./hardware/steam-hardware.nix
./hardware/system-76.nix
./hardware/tuxedo-keyboard.nix
./hardware/tuxedo-drivers.nix
./hardware/ubertooth.nix
./hardware/uinput.nix
./hardware/uni-sync.nix
Expand Down
2 changes: 1 addition & 1 deletion nixos/modules/services/hardware/tuxedo-rs.nix
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ in

config = mkIf cfg.enable (mkMerge [
{
hardware.tuxedo-keyboard.enable = true;
hardware.tuxedo-drivers.enable = true;

systemd = {
services.tailord = {
Expand Down
2 changes: 1 addition & 1 deletion pkgs/os-specific/linux/tuxedo-drivers/default.nix
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ stdenv.mkDerivation (finalAttrs: {
This driver provides support for Fn keys, brightness/color/mode for most TUXEDO
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: Is this description still accurate?

The features list seems to suggest no.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only the Hardware I/O driver for TUXEDO Control Center is missing, but the mentioned TUXEDO Control Center isn't even packaged here, and is used by tuxedo_rs instead.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then I would suggest to add "Hardware IO driver" without "for Tuxedo Control Center"

keyboards (except white backlight-only models).

Can be used with the "hardware.tuxedo-keyboard" NixOS module.
Can be used with the "hardware.tuxedo-drivers" NixOS module.
'';
maintainers = [ lib.maintainers.blanky0230 ];
platforms = lib.platforms.linux;
Expand Down