tuxedo-drivers: 3.2.14 -> 4.5.0 #316708
tuxedo-drivers: 3.2.14 -> 4.5.0 #316708
Conversation
|
I tested it on my Tuxedo Pulse Gen1 with the 6.6 Linux Kernel, but i would appreciate feedback for newer Tuxedo Models. |
| homepage = "https://gitlab.com/tuxedocomputers/development/packages/tuxedo-drivers"; | ||
| license = lib.licenses.gpl3Plus; | ||
| longDescription = '' | ||
| This driver provides support for Fn keys, brightness/color/mode for most TUXEDO |
There was a problem hiding this comment.
question: Is this description still accurate?
The features list seems to suggest no.
There was a problem hiding this comment.
Only the Hardware I/O driver for TUXEDO Control Center is missing, but the mentioned TUXEDO Control Center isn't even packaged here, and is used by tuxedo_rs instead.
There was a problem hiding this comment.
Then I would suggest to add "Hardware IO driver" without "for Tuxedo Control Center"
MinerSebas
force-pushed
the
tuxedo-drivers
branch
from
b1fd44c
to
b8ef83f
Compare
|
|
||
| meta = { | ||
| broken = stdenv.isAarch64 || (lib.versionOlder kernel.version "5.5"); | ||
| description = "Keyboard and hardware I/O driver for TUXEDO Computers laptops"; |
There was a problem hiding this comment.
| description = "Keyboard and hardware I/O driver for TUXEDO Computers laptops"; | |
| description = "Drivers for several platform devices for TUXEDO notebooks meant for the DKMS"; |
| homepage = "https://gitlab.com/tuxedocomputers/development/packages/tuxedo-drivers"; | ||
| license = lib.licenses.gpl3Plus; | ||
| longDescription = '' | ||
| This driver provides support for Fn keys, brightness/color/mode for most TUXEDO |
There was a problem hiding this comment.
Then I would suggest to add "Hardware IO driver" without "for Tuxedo Control Center"
|
Nice work! There is also this open pull request that intends to replace tuxedo-keyboard with tuxedo-drivers: #293017. I guess you can compare your implementation with theirs? Either way, once this has been merged, would it make sense to enable the package by default in nixos-hardware? |
|
I can confirm that this works on my Aura Gen1, using |
|
|
||
| mkdir -p "$out/lib/modules/${kernel.modDirVersion}" | ||
|
|
||
| for module in clevo_acpi.ko clevo_wmi.ko \ |
There was a problem hiding this comment.
#293017 uses INSTALL_MOD_PATH here, which I find nice
Description of changes
This updates the tuxedo-keyboard package to 4.5.0, and renames the package to its new upstream name.
While updating the nixos module, I also removed parts of the option description that were already removed in the 3.2.0 release.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 馃憤 reaction to pull requests you find important.