-
-
Notifications
You must be signed in to change notification settings - Fork 13.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
systemd: 255.9 -> 256.2 #307068
systemd: 255.9 -> 256.2 #307068
Conversation
With this PR, the generated initrd contains a This is an invalid path, so libkmod cannot be loaded, so the initrd fails to load any kernel module. |
This PR works for me when using a kernel that has everything built-in which is needed to boot, so no modules need to be loaded in stage 1. Therefore, kmod seems to be the only major thing that is currently broken. |
Should be fixed now for the systemd initrd. We needed to explicitly include libkmod in the initrd. The scripted initrd, however, is not working with the updated systemd and I have no idea how to fix it since I never use the scripted initrd. |
The changelog contains this entry:
but this PR does not set the mentioned configuration values when using the proprietary NVIDIA drivers. |
Indeed, this PR works with mandatory kernel modules when setting For merging this, either the scripted initrd needs to be fixed, or #287308 needs to be completed. Both options seem to be difficult. For fixing scripted initrd, this is a start:
This includes libkmod.so.2 in the initrd, but still fails at runtime. |
The way the scripted initrd patchelfs binaries is incompatible with the way we replace the |
@nikstur can you rebase this? |
Systemd 256 officially released in systemd-stable, should be able to use that now |
Looks like stable releases will be made from one repo now: https://github.com/systemd/systemd/blob/2af17b5e4c1aa67ed5bcaa105a2a36d4fac9061a/NEWS#L117 |
41e767f
to
6f959a9
Compare
w00t! |
oh my god! great job everyone that contributed to this! |
This broke the netboot image. Fix in: #331712 |
Commit 80be926 broke the autoPatchelf step in |
I think since this update plymouth is no longer working for me but I wasn't be able to get a useful log yet other than it existed. |
Can you create a new issue for this? We can start collecting logs there. I hope it's not too cursed :( |
Do not modify the rpath for dependencies that are present in libc. This reverts part of the change made in NixOS#307068 / 80be926. Fixes NixOS#332533
- Add keep_libc flag to disable the default libc handling. Intended to be used by systemd. - Add autoPatchelfFlags to autoPatchelfHook for passing arguments to the autoPatchelf script This reverts part of the change made in NixOS#307068 / 80be926. Fixes NixOS#332533
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/suspend-and-unsuspend-issues/50239/1 |
I am seeing a issue where systemd-oomd would activate in initrd and randomly kill processes like
|
Those logs are from the kernel OOM killer not systemd-oomd |
Which is even more weird with 16GB RAM... |
Those options were also added with systemd 256, but sadly were missed out in NixOS#307068. These options are documented in: - [systemd 256 changelog](https://github.com/systemd/systemd/releases/tag/v256) (search for `UseDomains=`) - [networkd.conf(5)](https://www.freedesktop.org/software/systemd/man/256/networkd.conf.html#UseDomains=) - [systemd.network(5)](https://www.freedesktop.org/software/systemd/man/256/systemd.network.html#UseDomains=)
Those options were also added with systemd 256, but sadly were missed out in NixOS#307068. These options are documented in: - [systemd 256 changelog](https://github.com/systemd/systemd/releases/tag/v256) (search for `UseDomains=`) - [networkd.conf(5)](https://www.freedesktop.org/software/systemd/man/256/networkd.conf.html#UseDomains=) - [systemd.network(5)](https://www.freedesktop.org/software/systemd/man/256/systemd.network.html#UseDomains=)
Description of changes
Closes #319328
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.