You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The osquery.toolchain package contains compiler toolchain binaries (like clang) and libc libraries to be used by the compiler outputs. When autoPatchelfHook is run on the package, it incorrectly adds the internal libc directory to the rpath of the compiler binaries. This causes the compiler binaries to break with an error message like this:
This was done because the systemd package wanted to use autoPatchelfHook to add .note.dlopen dependencies to its rpath. But using autoPatchelfHook to do this had an undesired side effect of removing glibc from the rpath (for a reason I don't yet understand). So autoPatchelfHooks previous behavior to ignore libc dependencies was changed.
Potential solutions
Add a flag to autoPatchelfHook telling it to leave libc in the rpath if it's found. Enable this only on systemd.
Revert the libc change to autoPatchelfHook altogether, and instead modify findLibs and make-initrd-ng to automatically check libc.
Either solution would restore the old libc behavior of autoPatchelfHook for everyone else. The former would then add different code for systemd, and the latter would change a couple other programs to account for lacking this new behavior
Describe the bug
The
osquery.toolchain
package contains compiler toolchain binaries (likeclang
) and libc libraries to be used by the compiler outputs. WhenautoPatchelfHook
is run on the package, it incorrectly adds the internal libc directory to the rpath of the compiler binaries. This causes the compiler binaries to break with an error message like this:This problem was introduced in #307068 / 80be926.
This was done because the systemd package wanted to use
autoPatchelfHook
to add.note.dlopen
dependencies to its rpath. But usingautoPatchelfHook
to do this had an undesired side effect of removing glibc from the rpath (for a reason I don't yet understand). SoautoPatchelfHook
s previous behavior to ignore libc dependencies was changed.Potential solutions
Either solution would restore the old libc behavior of autoPatchelfHook for everyone else. The former would then add different code for systemd, and the latter would change a couple other programs to account for lacking this new behavior
@ElvishJerricco @flokli
The text was updated successfully, but these errors were encountered: