Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/usbStorage: update device flag #265030

Merged
merged 1 commit into from
Jan 8, 2024
Merged

Conversation

bb2020
Copy link
Member

@bb2020 bb2020 commented Nov 2, 2023

Description of changes

Fixes #265013

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@bb2020
Copy link
Member Author

bb2020 commented Dec 11, 2023

Tested this today with an external drive.

~ grep -rn --include 'manage*start_stop' . /sys/devices/ 
/sys/devices/pci0000:00/0000:00:14.0/usb2/2-4/2-4:1.0/host0/target0:0:0/0:0:0:0/scsi_disk/0:0:0:0/manage_system_start_stop:1:0
/sys/devices/pci0000:00/0000:00:14.0/usb2/2-4/2-4:1.0/host0/target0:0:0/0:0:0:0/scsi_disk/0:0:0:0/manage_runtime_start_stop:1:0
/sys/devices/pci0000:00/0000:00:14.0/usb2/2-4/2-4:1.0/host0/target0:0:0/0:0:0:0/scsi_disk/0:0:0:0/manage_start_stop:1:0

@bb2020 bb2020 marked this pull request as ready for review December 11, 2023 19:57
@bb2020
Copy link
Member Author

bb2020 commented Jan 5, 2024

Can you merge this @AndersonTorres ?

@AndersonTorres
Copy link
Member

No :(

@bb2020 bb2020 requested a review from Ma27 January 5, 2024 09:39
@ElvishJerricco ElvishJerricco merged commit 9127f63 into NixOS:master Jan 8, 2024
21 checks passed
@bb2020
Copy link
Member Author

bb2020 commented Jan 14, 2024

I set manage_system_start_stop to replicate the old behavior.
I presume el-cheapo USB devices won't be able to wake up after suspend if we set manage_runtime_start_stop.

It looks like they've made another change in torvalds/linux@24eca2d.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

manage_start_stop device attribute is now readonly
3 participants