rocprofiler: init at 5.3.3 #203226
Closed
rocprofiler: init at 5.3.3 #203226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afb1545
to
3ab335b
Compare
| version = finalAttrs.rocmVersion; | ||
|
|
||
| src = fetchurl { | ||
| url = "https://repo.radeon.com/rocm/apt/${finalAttrs.rocmVersion}/pool/main/h/${finalAttrs.pname}/${finalAttrs.pname}_1.0.0.${finalAttrs.modVersion}-${finalAttrs.magicVersion}~${finalAttrs.ubuntuVersion}_amd64.deb"; |
There was a problem hiding this comment.
Would recommend to use a with finalAttrs for this one line to reduce code duplication
| stdenv.mkDerivation (finalAttrs: { | ||
| pname = "hsa-amd-aqlprofile"; | ||
| rocmVersion = "5.3.3"; | ||
| modVersion = with lib.strings; concatStrings (intersperse "0" (splitString "." finalAttrs.rocmVersion)); |
There was a problem hiding this comment.
Suggested change
| modVersion = with lib.strings; concatStrings (intersperse "0" (splitString "." finalAttrs.rocmVersion)); | |
| modVersion = with lib; concatStrings (intersperse "0" (splitString "." finalAttrs.rocmVersion)); |
Comment on lines
+41
to
+42
| patchShebangs test/run.sh | ||
| patchShebangs bin/*.sh |
There was a problem hiding this comment.
Suggested change
| patchShebangs test/run.sh | |
| patchShebangs bin/*.sh | |
| patchShebangs test/run.sh bin/*.sh |
| ''; | ||
|
|
||
| postInstall = '' | ||
| patchelf --set-rpath ${lib.makeLibraryPath (finalAttrs.nativeBuildInputs ++ finalAttrs.buildInputs)}:$out/lib $out/lib/rocprofiler/librocprof-tool.so* |
There was a problem hiding this comment.
We cannot combine nativeBuildInputs with buildInputs because they have different arches when cross compiling.
|
Rolled into #206421 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Tracking: #197885
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes