Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Revert "Adapt scheduler to work with dynamic derivations #9415

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Ericson2314
Copy link
Member

@Ericson2314 Ericson2314 commented Nov 20, 2023

Motivation

This fixes dynamic derivations, reverting #9081.
#9052 However will be reintroduced unless this is modified somehow.

Context

This reverts commit 8440afb.

Priorities

Add 👍 to pull requests you find important.

@github-actions github-actions bot added the with-tests Issues related to testing. PRs with tests have some priority label Nov 20, 2023
@roberth roberth added the RFC Related to an accepted RFC label Nov 21, 2023
@roberth
Copy link
Member

roberth commented Mar 22, 2024

This might be a tall order, but could this change be split?
That'd be one way to make progress and narrow down where the problem really is.

This fixes dynamic derivations, reverting #9081. #9052 However will be
reintroduced unless this is modified somehow.

This reverts commit 8440afb.
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/pre-rfc-implement-dependency-retrieval-primitive/43418/9

@roberth
Copy link
Member

roberth commented Jul 3, 2024

I believe the changes after #11005 will either uncover or silently fix the bug.

@L-as
Copy link
Member

L-as commented Jul 3, 2024

I wouldn't be so sure yet; I haven't rewritten DerivationGoal.

But the subsequent PRs will.

@roberth
Copy link
Member

roberth commented Jul 4, 2024

@L-as yeah, I meant after, and it is only a belief.
I didn't mean to set a bar for your work; I just wanted to highlight it because I think it's good, and helpful for delivering dynamic derivations.

@Ericson2314
Copy link
Member Author

Yeah I think it will help too: there is no more need for outer derivation goal with that change, because we don't need separate types just to have different local variables persisted across yield points.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RFC Related to an accepted RFC scheduling with-tests Issues related to testing. PRs with tests have some priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants