Revert "Adapt scheduler to work with dynamic derivations" #9081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5148a4a
to
d85a08c
Compare
This reverts commit 5e3986f. This un-implements RFC 92 but fixes the critical bug NixOS#9052 which many people are hitting. This is a decent stop-gap until a minimal reproduction of that bug is found and a proper fix can be made. Mostly fixed NixOS#9052, but I would like to leave that issue open until we have a regression test, so I can then properly fix the bug (unbreaking RFC 92) later.
d85a08c
to
8440afb
Compare
|
Successfully created backport PR for |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/2023-10-02-nix-team-meeting-minutes-91/33775/1 |
12 tasks
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin 2.18-maintenance
git worktree add -d .worktree/backport-9081-to-2.18-maintenance origin/2.18-maintenance
cd .worktree/backport-9081-to-2.18-maintenance
git switch --create backport-9081-to-2.18-maintenance
git cherry-pick -x 8440afbed756254784d9fea3eaab06649dffd390 |
1 similar comment
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin 2.18-maintenance
git worktree add -d .worktree/backport-9081-to-2.18-maintenance origin/2.18-maintenance
cd .worktree/backport-9081-to-2.18-maintenance
git switch --create backport-9081-to-2.18-maintenance
git cherry-pick -x 8440afbed756254784d9fea3eaab06649dffd390 |
|
(manual backport has been done) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This reverts commit 5e3986f. This un-implements RFC 92 but fixes the critical bug #9052 which many people are hitting. This is a decent stop-gap until a minimal reproduction of that bug is found and a proper fix can be made.
Context
Mostly fixed #9052, but I would like to leave that issue open until we have a regression test, so I can then properly fix the bug (unbreaking RFC 92) later.
Priorities
Add 👍 to pull requests you find important.