Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

처음에 반다라트가 1개일때 반다라트를 삭제했을 때, 새로운 반다라트가 생성되지 않고 무한 스켈레톤이 발생하는 문제 해결 #80

Merged
merged 2 commits into from
Aug 22, 2023

Conversation

easyhooon
Copy link
Collaborator

@easyhooon easyhooon commented Aug 22, 2023

#79

@easyhooon easyhooon self-assigned this Aug 22, 2023
@easyhooon easyhooon added the hotfix tasks related to fix bugs label Aug 22, 2023
@easyhooon easyhooon enabled auto-merge (squash) August 22, 2023 05:24
// 반다라트 목록이 존재하지 않을 경우, 새로운 반다라트를 생성
if (bandalartList.isEmpty()) {
_uiState.value = _uiState.value.copy(isNetworking = false)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

아 이런경우가 있었구먼 굿굿

@@ -23,14 +23,23 @@ import kotlinx.coroutines.runBlocking
import kotlinx.serialization.json.Json
import timber.log.Timber

private const val MaxTimeoutMillis = 3000L
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

앱이 죽는 것인데 혹시 이거로 해결이 된 부분이 있어?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

앱이 원래도 죽진 않고 먹통이 되는거가 문제 였는데 15초가 너무 길다고 생각이 들어서 좀 줄여봤어

@easyhooon easyhooon merged commit 518364b into develop Aug 22, 2023
1 check passed
@easyhooon easyhooon deleted the feature/fix-bandalart-delete-bug branch August 22, 2023 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotfix tasks related to fix bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants