Merge dev into 0.6 #717
Merged
Merge dev into 0.6 #717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added keepalive for dynomite listen connection
Each rack has a 'struct continuum' pointer in it. This is used to determine which token belongs to which node (see dyn_vnode.c). While it has only a single pointer, the code uses it as though it's an array of struct pointers. This potentially could lead to a lot of confusion. This patch addresses this by explicitly changing the member to an array of structs. Manually tested to make sure that there is no change to how the keys are sharded.
Treat each rack continuum as an array
SCRIPT EXISTS was using the wrong message routing option causing all the replica messages to go to the local redis instance. And Dynomite would crash since it processes only one of the 3 replies that Redis returns, leaving the local redis server message queue in an inconsistent state.
Fix SCRIPT EXISTS crash
…ort ZSET The read repair infra did not allow for commands with optional support to be read-repairable. Now, this functionality is added which lets us support more Redis commands. ZADD is the first command with optional arguments to have read-repair support. ZSCORE and ZREM are also supported for read repairs. As with the other commands, range queries are not repairable yet, and will be added as a follow on patch.
Allow commands with optional arguments to be read-repairable and supp…
When read repairs are enabled, we attempt to keep a track of the last parsed mbuf if the request is large enough to be split across multiple buffers. The code would previously update the latest_parsed_mbuf_idx field if the current token length surpassed (mbuf)->last. This turns out to be incorrect since we may parse with partial network reads as well. The fix is to check if mbuf_full() before updating said index. Confirmed its working with large requests across mbufs and partial network read requests.
Fix crash during a MSG_PARSE_AGAIN parse state w/ repairs
msg_repair() seems to have been broken in previous patches. This patch undoes the changes made to it earlier. Revist if removing it causes issues in the future.
Fix msg_repair()
Fixes msg memory leak
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.