Treat each rack continuum as an array #694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tharanga
approved these changes
Aug 21, 2019
tharanga
reviewed
Aug 21, 2019
Each rack has a 'struct continuum' pointer in it. This is used to determine which token belongs to which node (see dyn_vnode.c). While it has only a single pointer, the code uses it as though it's an array of struct pointers. This potentially could lead to a lot of confusion. This patch addresses this by explicitly changing the member to an array of structs. Manually tested to make sure that there is no change to how the keys are sharded.
smukil
force-pushed
the
cleanup_vnode_code
branch
from
8aa93f1
to
ac2c4ad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each rack has a 'struct continuum' pointer in it. This is used to determine
which token belongs to which node (see dyn_vnode.c).
While it has only a single pointer, the code uses it as though it's
an array of struct pointers. This potentially could lead to a lot of
confusion.
This patch addresses this by explicitly changing the member to an array
of structs.
Manually tested to make sure that there is no change to how the keys are
sharded.