Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reorganizing QDM related methods #216

Merged
merged 8 commits into from
May 24, 2024
Merged

Reorganizing QDM related methods #216

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
e01dac8
refact: Relocating FillAndSmoothMixin
castelao May 20, 2024
3ddd2c0
refact: Relocating QuantileDeltaMappingCorrection
castelao May 20, 2024
901b22b
fix: Removing unused imports
castelao May 20, 2024
89b4bab
Defining `__all__` for bias
castelao May 20, 2024
a91f4c5
style: Drop coding utf-8 since that is already the default
castelao May 20, 2024
9456dd3
Combining ruff setup from PR #215
castelao Apr 18, 2024
3abc643
fix: Updating how to access QuantileDeltaMappingCorrection
castelao May 22, 2024
c69951c
refact: local_qdm_bc available as a bias resource
castelao May 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
refact: local_qdm_bc available as a bias resource 
Following the pattern, `local_qdm_bc` should be available as a bias
resource as well. I missed that when I was implementing it.
  • Loading branch information
@castelao
castelao committed May 22, 2024
commit c69951c60fe614780c265b6643ffde41b8171aa3
3 changes: 2 additions & 1 deletion sup3r/bias/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,15 @@
"""Bias calculation and correction modules."""

from .bias_transforms import (global_linear_bc, local_linear_bc,
monthly_local_linear_bc)
local_qdm_bc, monthly_local_linear_bc)
from .bias_calc import (LinearCorrection, MonthlyLinearCorrection,
SkillAssessment)
from .qdm import QuantileDeltaMappingCorrection

__all__ = [
"global_linear_bc",
"local_linear_bc",
"local_qdm_bc",
"monthly_local_linear_bc",
"LinearCorrection",
"MonthlyLinearCorrection",
Expand Down
3 changes: 1 addition & 2 deletions tests/bias/test_qdm_bias_correction.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,7 @@
from sup3r import CONFIG_DIR, TEST_DATA_DIR
from sup3r.models import Sup3rGan
from sup3r.pipeline.forward_pass import ForwardPass, ForwardPassStrategy
from sup3r.bias import QuantileDeltaMappingCorrection
from sup3r.bias.bias_transforms import local_qdm_bc
from sup3r.bias import local_qdm_bc, QuantileDeltaMappingCorrection
from sup3r.preprocessing.data_handling import DataHandlerNC, DataHandlerNCforCC

FP_NSRDB = os.path.join(TEST_DATA_DIR, "test_nsrdb_co_2018.h5")
Expand Down
Loading