Reorganizing QDM related methods #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The bias_calc was getting too large so let's break it in parts to make is easier to maintain and navigate. Creating a new sub-module mixins.
The bias_calc was already quite large before adding PresRat. This commit relocates QuantileDeltaMappingCorrection in a new sub-module that will also receive PresRat.
Defining what to expose with wildcard.
Since UTF-8 has been the default in a while, it is not recommended anymore using: '# -*- coding: utf-8 -*-'
To keep the following PR cleaner, this commit moves and combines a few ruff setup from that PR into here. style: Adding 'F' into ruff's checks It seems to be the only one conforming. cfg: Missing to ignore F401 Following @bnb32 setup. style: Ignore F401 only on __init__ Thanks to @ppinchuk 's tip! I missed that before. Ignoring unused import in docs Including Warning (W) rules
Using it as a bias' resource, and doesn't need to know how it is organized internally.
Following the pattern, `local_qdm_bc` should be available as a bias resource as well. I missed that when I was implementing it.
|
@grantbuster and @bnb32 , may I merge this one? |
grantbuster
approved these changes
May 23, 2024
github-actions bot
pushed a commit
that referenced
this pull request
May 24, 2024
Reorganizing QDM related methods
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
bias_calcwas already getting too large, so let's split and reorganize it.This PR is meant to simplify the review of the following
PresRat. Here, it is mostly about moving things around. Any error would be due to paths accessing components of the library, but the actual existing methods are not changed. ThePresRatwill be implemented inbias_calc.qdm, on the side of the standardQDM.