Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix logic errors #138

Merged
merged 2 commits into from
Oct 7, 2021
Merged

fix logic errors #138

merged 2 commits into from
Oct 7, 2021

Conversation

menzel-gfdl
Copy link
Contributor

Description

Small updates to fix a bug in how fms2 I/O is used to read in a nudge dataset.

Fixes #137

How Has This Been Tested?

We are currently testing this in a run of AM4 using a MERRA dataset.

Checklist:

Please check all whether they apply or not

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@bensonr
Copy link
Contributor

bensonr commented Sep 9, 2021

@menzel-gfdl - once your test has completed, please update the PR information. Double checking, your test using the newly created 2021.03.01 tag + fix - correct?

@menzel-gfdl
Copy link
Contributor Author

@bensonr yes this is still a work in progress until we run more tests. Oops, I made that branch off of the 2021.03 tag. I'll merge the 2021.03.01 tag into that branch.

uramirez8707
uramirez8707 approved these changes Sep 16, 2021
View reviewed changes
Copy link
Contributor

@uramirez8707 uramirez8707 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks good to me.

@bensonr
Copy link
Contributor

bensonr commented Sep 16, 2021

@menzel-gfdl - any update on your testing?

@laurenchilutti
Copy link
Contributor

@menzel-gfdl is this still a work in progress, or is it ready?

@menzel-gfdl
Copy link
Contributor Author

@bensonr @laurenchilutti I am not sure. Is there a standard "nudged" experiment in our rts suite? If not, can we add one and them make sure this code reproduces the non-fms2-io version?

@laurenchilutti
Copy link
Contributor

@menzel-gfdl It appears that we don't have a test for this in our RTS suite as this issue was never caught in our regression testing. But, it might not be necessary to add one because this file is rarely touched.

@menzel-gfdl
Copy link
Contributor Author

I spoke to someone and got an experiment that uses this code. @uramirez8707, I will chat you tomorrow about maybe adding the experiment to the awg testing xml.

@bensonr bensonr merged commit 03e4164 into NOAA-GFDL:dev/gfdl Oct 7, 2021
laurenchilutti pushed a commit that referenced this pull request Oct 7, 2021
@menzel-gfdl @laurenchilutti
fix logic errors (#138)
c7f0f50
@menzel-gfdl
Copy link
Contributor Author

@bensonr @laurenchilutti I think this fix I put in changes answers. It needs to be investigated further.

@menzel-gfdl menzel-gfdl mentioned this pull request Oct 8, 2021
Closed
@laurenchilutti
Copy link
Contributor

@menzel-gfdl Was the calendar issue what changed answers for you? Or do we still need to investigate further?

@menzel-gfdl
Copy link
Contributor Author

I think there is still another issue. I have an idea, but need to try it out.

@menzel-gfdl menzel-gfdl mentioned this pull request Oct 8, 2021
Merged
6 tasks
laurenchilutti added a commit that referenced this pull request Oct 13, 2022
@laurenchilutti @bensonr
@menzel-gfdl @MatthewPyle-NOAA @lharris4 @MicroTed
Dev/gfdl test (#222)
721e6f7 
* updated fv_regional_bc.F90 to read levsp from GFS_ctl file (#152)

* Updating a continue statement in fv_nudge (#153)

* update in fv_nudge to fix 666 label logic

* fix logic errors (#138)

* update to external_ic::remap_scale to skip remapping non-existent IC tracers (#159)

* Fix nudge logic (#157)

* fix logic errors

* fix answer changes

* adding back a line that was mistakenly deleted in a previous commit (#166)

* Release 042022 (#184)

* Merge of updates from GFDL Weather and Climate Dynamics Division (202204):

    *add license header to missing files and fix typo in header

    *updates needed for fv3_gfsphysics to have access to bounded_domain

    *remove obsoleted driver/SHiELD files

    *updating to fix bug where long_name and units attributes were not being captured in the RESTARTS

    *remove unused function fv_diagnostics::max_vorticity_hy1

    *remove avec timer remnants

    *adding ability to specify prefix and directory when reading and writing restarts

    *remove old style namelist read in favor of read from internal character variable

    *Added option for a mean wind

    *The planetary radius and rotation rate are now re-scalable by a namelist parameter (small_earth_scale) instead of using exclusively the hard-coded FMS constant.

    *fv_mapz: Cleanup and added helpful annotations to avoid getting lost so easily

    * remove duplicate code and fix lstatus on all grids depending on gfs_data and gfs_data.tile1

    * New idealized tests

    *Makes the non-hydrostatic restart variables optional for reads to allow hydrostatic ICs

    *Fix the hydrostatic TE remapping; Add GMAO cubic for TE remapping, which is used if kord_tm=0 and remap_te=.true.

    *Add a TE remapping option (kord_tm=0)

    *Addressing GNU Warnings

    *Add the L75 vertical config from HAFS

    * clean up fms_mp_mod and remove mp_bcst

* cherry pick 5193c6b from dev/emc

* Attempt at integrating fixes on top of dev/emc branch. (#173)

* remove outdated GFDL_tools/fv_diag_column.F90 which exists as the result of an improper merge.  The correct file is tools/fv_diag_column.F90 (#191)

* various io fixes (#192)

* fixes io performance issues by making everyone a reader when io_layout=1,1

adds capability to use FMS feature to ignore data integrity checksums in restarts

* rename enforce_rst_cksum to ignore_rst_cksum and change the default value for compatibility

* fix index error (#196)

* New notebooks (#190)

* Moving source files into source directory

* Added advection notebook

* Fixed subplot spacing

* New 3D case notebooks

* New idealized tests

Updated mtn_wave_tests_1km to restore missing graphics.

* first try at held-suarez

* Updated H-S superrotation notebook

* New level placement tool in an interactive note

* Minor updates to notebooks; deleted fv_eta binary.

* Regional decomposition test fix (when nrows_blend > 0) (#194) (#200)

* Regional bc blend changes to extend into interior halos and overlap on corners. Still not working for u and v.

dyn_core.F90 : Fix from Jun Wang to correct sync of u,v
fv_regional_bc.F90 : add check for nrows_blend > tile size; fix error when nrows_blend=1

Conflicts (not taken during chery-pick):
	driver/SHiELD/atmosphere.F90
	model/fv_sg.F90

Co-authored-by: Ted Mansell <[email protected]>

* Implementing CI (#207)

* CI Parallelworks update (#211)

* Update call to read_input_nml and remove unnecessary code. (#161)

* Removing use of INTERNAL_FILE_NML and cleaning up read_namelist_test_cases to remove unused argument

* deleting duplicate call to read_namelist_test_case_nml in fv_control

* removing commented code in fv_control

Co-authored-by: Rusty Benson <[email protected]>
Co-authored-by: menzel-gfdl <[email protected]>
Co-authored-by: Rusty Benson <[email protected]>
Co-authored-by: MatthewPyle-NOAA <[email protected]>
Co-authored-by: lharris4 <[email protected]>
Co-authored-by: Ted Mansell <[email protected]>
@laurenchilutti laurenchilutti mentioned this pull request Jan 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bensonr bensonr bensonr approved these changes

@uramirez8707 uramirez8707 uramirez8707 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@menzel-gfdl @bensonr @laurenchilutti @uramirez8707