Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial Work toward Webpack 5 with Svue #89

Closed
wants to merge 11 commits into from
Closed

Initial Work toward Webpack 5 with Svue #89

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
db67a20
remove comment
thadk Feb 7, 2022
7fcb10e
use typescript without it being part of webpack
thadk Feb 18, 2022
dc2ab1f
tweak makefile with npm list
thadk Feb 22, 2022
2bc6f92
Makefile tweaks
thadk Feb 22, 2022
2e7c22b
webpack 5 starting point
thadk Feb 22, 2022
0fa3f63
working with Hotmodulereloading off and other tweaks
thadk Feb 22, 2022
b453f88
turn off hot reload, restore speed test with
thadk Feb 22, 2022
2f96de2
comment
thadk Feb 22, 2022
d95b56d
update staging config file for node 16
thadk Feb 22, 2022
969e2bd
svelte-check-plugin and resolve warnings, devServer hot load
thadk Feb 22, 2022
da3cbb7
fix webpack 5 removing hmr from css
thadk Feb 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
remove comment
  • Loading branch information
@thadk
thadk committed Feb 7, 2022
commit db67a20042d248a052921e5a0182bc1175665565
15 changes: 3 additions & 12 deletions src/pages/app/menus/AddonMenuItem.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,26 +1,20 @@
<script>
import MenuItem from "@/common/MenuItem";
import Tooltip from "@/common/Tooltip";
import { layout, dispatchAddonSelected,openDispatchAddon } from "@/manager/layout";
import {
selectedDocsInProject,
// addSelectedDocsToProject,
// removeSelectedDocsFromProject,
} from "@/manager/addons";
import { layout, openDispatchAddon } from "@/manager/layout";
import { handlePlural } from "@/util/string";

export let addon;

$: scope = "none"
// $layout.selected.length > 0 ? selectedDocsInProject(addon) : "none";


$: caption =
scope == "fully"
? `Remove ${handlePlural(
$layout.selected.length,
"document",
)} from next addon dispatch`
: `Add ${handlePlural($layout.selected.length, "document")} to next addon dispatch`;
: `Add ${handlePlural($layout.selected.length, "document")} to an addon dispatch`;

function handleClick() {
openDispatchAddon(addon)
Expand All @@ -38,8 +32,5 @@
<MenuItem on:click={handleClick}>
<Tooltip delay={500} {caption}>
{addon.name}
<span class="scope">
<!-- {#if scope == "fully"}✓{/if} -->
</span>
</Tooltip>
</MenuItem>