Initial Work toward Webpack 5 with Svue #89
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
documentcloud-frontend/src/Main.svelte Line 145 in 2e7c22b |
Merged
| @@ -131,8 +131,8 @@ | |||
| background: rgba($primary, 0.18); | |||
| left: 50%; | |||
| top: 50%; | |||
| margin-left: -$circleSize / 2; | |||
| margin-top: -$circleSize / 2; | |||
| margin-left: -$circleSize * 0.5; | |||
There was a problem hiding this comment.
Why is multiplying by 0.5 better than dividing by 2?
| @@ -83,6 +83,7 @@ | |||
| on:click={() => dismiss(i)} | |||
| on:mouseover={reset} | |||
| on:mousemove={reset} | |||
| on:focus={() => null} | |||
| @@ -250,7 +250,10 @@ | |||
| } | |||
| } | |||
|
|
|||
| :global(h5, h6) { | |||
| :global(h5) { | |||
| @@ -1,22 +1,45 @@ | |||
| const MiniCssExtractPlugin = require("mini-css-extract-plugin"); | |||
| /* TODO: switch to imports instead of require https://github.com/baileyherbert/svelte-webpack-starter/blob/main/webpack.config.ts */ | |||
| hotReload: false, /* Turned off for newer versions */ | ||
| hotOptions: { /* | ||
| TK none of these alternated, non-default settings seem fix the | ||
| underlying problem with Svue |
There was a problem hiding this comment.
What is the problem with Svue?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/sveltejs/language-tools/issues/650)node-sasswithdart-sass?devServerfrom v3 to v4svelte-preprocessv3 to v4 https://github.com/sveltejs/svelte-preprocess/blob/main/docs/migration-guide.md