Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#4 Create new arguments #217

Merged
merged 18 commits into from
Jun 26, 2024
Merged

#4 Create new arguments #217

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
7e63978
Added post-new-argument form; Added API base for posting new argument…
Monstarrrr Jun 23, 2024
bc62199
submitButtonLabel fix
Monstarrrr Jun 23, 2024
f65b608
Formatting data
Monstarrrr Jun 23, 2024
b05ff8c
Add arguments & fetch them
Monstarrrr Jun 25, 2024
1da642f
Fix types
Monstarrrr Jun 25, 2024
3046c21
Edited post tests
Monstarrrr Jun 25, 2024
916c103
remove deprecated comments and use camelCase
seporterfield Jun 25, 2024
31ec470
add conventions to CONTRIBUTING.md
seporterfield Jun 25, 2024
2579448
validate against post types from models.py
seporterfield Jun 25, 2024
9f6c1fc
remove redundant verifier
seporterfield Jun 25, 2024
30ca551
added auth for PostViewSet
seporterfield Jun 25, 2024
a7dec91
remove print debugs
seporterfield Jun 25, 2024
4fd2527
add arguments viewset and posts permissions
seporterfield Jun 26, 2024
723c18c
disable basic and session auth
seporterfield Jun 26, 2024
7ef24be
fix: broken/jumbled tests
seporterfield Jun 26, 2024
9e1ecac
fix: missing comma
seporterfield Jun 26, 2024
288b392
fix: IsOwnerOrReadOnly checks for userOwnerId
seporterfield Jun 26, 2024
e058bcb
fix: permission logic
seporterfield Jun 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
submitButtonLabel fix
  • Loading branch information
@Monstarrrr
Monstarrrr committed Jun 23, 2024
commit bc62199a508e7ff36a87b5864d8dda6bbceaffa4
4 changes: 2 additions & 2 deletions frontend/app/_components/form.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import { ChangeEvent, useEffect, useState } from 'react'

export default function Form(props: FormProps) {
const {
buttonLabel,
submitButtonLabel,
id,
inputsErrors,
inputsFields,
Expand Down Expand Up @@ -136,7 +136,7 @@ export default function Form(props: FormProps) {
{successMessage && <span style={{ color: 'green' }}>{successMessage}</span>}
<br />
<button disabled={loading} type='submit'>
{loading ? 'Loading...' : buttonLabel}
{loading ? 'Loading...' : submitButtonLabel}
</button>
</form>
)
Expand Down