Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#4 Create new arguments #217

Merged
merged 18 commits into from
Jun 26, 2024
Merged

#4 Create new arguments #217

merged 18 commits into from
Jun 26, 2024

Conversation

Monstarrrr
Copy link
Owner

@Monstarrrr Monstarrrr commented Jun 23, 2024 •
edited
Loading

  • Added post-new-argument form; Added API base for posting new argument (untested)
  • submitButtonLabel fix
  • Add arguments & fetch them

@vercel Vercel
Copy link

vercel bot commented Jun 23, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rebutify ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 26, 2024 2:57am

@Monstarrrr Monstarrrr mentioned this pull request Jun 25, 2024
Closed
This was linked to issues Jun 25, 2024
Create ViewSet for Arguments #216
Closed
Create new arguments #4
Closed
@seporterfield seporterfield marked this pull request as ready for review June 26, 2024 02:58
@seporterfield seporterfield self-requested a review June 26, 2024 03:17
@seporterfield seporterfield merged commit 6b7140b into main Jun 26, 2024
10 checks passed
@seporterfield seporterfield deleted the feat/4_add-arguments branch June 26, 2024 03:17
@seporterfield seporterfield restored the feat/4_add-arguments branch June 26, 2024 03:20
@seporterfield seporterfield mentioned this pull request Jun 26, 2024
Merged
@Monstarrrr
Copy link
Owner Author

Monstarrrr commented Jun 26, 2024 •
edited
Loading

Didn't know you could self approve your changes and merge xD

@seporterfield
Copy link
Collaborator

Didn't realize either
It seems it's as long as someone else requested your review, no matter what changes you make you can approve and merge.

@Monstarrrr
Copy link
Owner Author

Didn't realize either
It seems it's as long as someone else requested your review, no matter what changes you make you can approve and merge.

Good job, github

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seporterfield seporterfield seporterfield approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create ViewSet for Arguments Create new arguments
2 participants
@Monstarrrr @seporterfield