Increase level of warnings, fix some possible uninitialized values #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Start ifort section
Found with `gfortran -O2 -Wmaybe-uninitialized`, however not all resolved so keep `-Wno-maybe-uninitialized` for now.
langevin-usgs
approved these changes
Mar 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "gold standard" of warnings is to turn most of them on with
-Wall(or-warn allfor Intel). While this PR doesn't exactly do this, it does add most of them... and then turns off other warnings that may require more attention later (if any) using-Wno-...Also,
fflagsnow configured for breaking change from modflowpy/pymake#28Some manual work with
gfortran -O2 -Wmaybe-uninitializedwas done to try and resolve some potential uninitialized values for mt3dms and mt3d-usgs. Note that none of these are confirmed as bugs. However, not all of these warnings were resolved due to possible false positive GCC bugs (maybe), so-Wno-maybe-uninitializedis used to disable this warning for now. Also, this flag didn't help discover #46 so there are possibly other variables lurking that would require other tools (e.g. Intel or Valgrind) to identify.