Initialize velocity component array #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mwtoews thanks so much for digging in and finding this bug. The erratic nature of that uninitialized variable was frustrating. @emorway-usgs, it would probably be a good idea to do some more checking with some of the intel tools to find if any other uninitialized variables are being used anywhere in the program. |
|
This fix offered in this pull request has been referenced by modflowpy/flopy#466 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With gfortran, the velocity component array was left uninitialized, sometimes with NaNs (or not). This creates an issue where models sometimes hit a floating point exception and crash (or not), about 50% of the time. For example,
p09inflopy3_MT3DMS_examples.ipynbsometimes crashesmt3dms. This bug behaved similarly inmt3d-usgs.