Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates text to be tolerant of macOS typo. #96

Closed

Conversation

kevingriffin
Copy link
Contributor

This change is necessary to build on modern Macs with nix.
Full details: NixOS/nixpkgs#91716

Summary: nix-provided Python will emit an older version of macOS than the actual target when get_platform() is called.
This means tests expect a misspelled error message, when in fact the system will emit the error with correct spelling.

This change is necessary to build on modern Macs
with nix. See NixOS/nixpkgs#91716
@coveralls
Copy link

coveralls commented Jul 5, 2020

Coverage Status

Coverage remained the same at 28.518% when pulling 4f58ac0 on kevingriffin:macos-test-fix into ab4e795 on LudovicRousseau:master.

@LudovicRousseau
Copy link
Owner

Fixed in 945e9c4
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants