pythonPackages.pyscard: Fix build on Darwin #91717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
added
6.topic: darwin
veprbl
reviewed
Jun 29, 2020
veprbl
reviewed
Jul 6, 2020
| # See: https://github.com/LudovicRousseau/pyscard/issues/77 | ||
| # Building with python from nix on macOS version 10.13 or | ||
| # greater still causes this issue to occur. | ||
| patches = optionals withApplePCSC [ ./ignore-macos-bug.patch ]; |
There was a problem hiding this comment.
Suggested change
| patches = optionals withApplePCSC [ ./ignore-macos-bug.patch ]; | |
| patches = optionals withApplePCSC [ | |
| (fetchpatch { | |
| url = "https://github.com/LudovicRousseau/pyscard/commit/945e9c4cd4036155691f6ce9706a84283206f2ef.patch"; | |
| sha256 = "19n8w1wzn85zywr6xf04d8nfg7sgzjyvxp1ccp3rgfr4mcc36plc"; | |
| }) | |
| ]; |
There was a problem hiding this comment.
Thanks! I made this change, removed the patch file, and squished it all into the original commit.
The previously provided patch is still necessary, as nix python reports an old version of macOS that has the bug, when in fact modern macOS does not have the misspelling. The patch has been upstreamed, so we take it to fix 1.9.9 in anticipation of the next release.
kevingriffin
force-pushed
the
pyscard-darwin-199-fix
branch
from
20e326f
to
d0c641e
Compare
|
@GrahamcOfBorg build python27Packages.pyscard |
veprbl
approved these changes
Jul 7, 2020
jonringer
approved these changes
Jul 7, 2020
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previously provided patch is still necessary,
as nix python reports an old version of macOS
that has the bug, when in fact modern macOS
does not have the misspelling.
Motivation for this change
Fixes #91716
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)