Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix or mitigate bare/overgeneral exception handlers #5

Merged
merged 4 commits into from
Jun 29, 2015
Merged

Fix or mitigate bare/overgeneral exception handlers #5

merged 4 commits into from
Jun 29, 2015

Commits on Jun 29, 2015

  1. Fix two pylint bare-except warnings 

    Errors should not pass sliently, bare except blocks risk hiding errors
that should not be caught such as SyntaxError
    @moreati
    moreati committed Jun 29, 2015
    Configuration menu
    Copy the full SHA
    facd3da View commit details
    Browse the repository at this point in the history

  2. Fix pylint bare-except warnings in examples/test suite/scripts

    @moreati
    moreati committed Jun 29, 2015
    Configuration menu
    Copy the full SHA
    78d0867 View commit details
    Browse the repository at this point in the history

  3. Mitigate pylint bare-except/overgeneral-exceptions warnings 

    CardMonitoringThread and ReaderMonitoringThread encapsulate lots of code
, any which could raise a wide variety of exceptions. Fixing this is not
feasible at the moment, the best we can do is provide better feedback
about the origins of an exception - by printing the full traceback,
including the line numbers.
    @moreati
    moreati committed Jun 29, 2015
    Configuration menu
    Copy the full SHA
    e84c0b9 View commit details
    Browse the repository at this point in the history

  4. Make import of smartcard.scard predictable & fix a pylint bare-except… 

    … warning

Importing smartcard.pyscard should either succeed in using the generated
scard.py wrapper, or fail. Silently importing _scard.so in place of the
wrapper risks creating hard-to-diagnose heisenbugs.
    @moreati
    moreati committed Jun 29, 2015
    Configuration menu
    Copy the full SHA
    f667a77 View commit details
    Browse the repository at this point in the history