Fix or mitigate bare/overgeneral exception handlers #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Errors should not pass sliently, bare except blocks risk hiding errors that should not be caught such as SyntaxError
CardMonitoringThread and ReaderMonitoringThread encapsulate lots of code , any which could raise a wide variety of exceptions. Fixing this is not feasible at the moment, the best we can do is provide better feedback about the origins of an exception - by printing the full traceback, including the line numbers.
… warning Importing smartcard.pyscard should either succeed in using the generated scard.py wrapper, or fail. Silently importing _scard.so in place of the wrapper risks creating hard-to-diagnose heisenbugs.
LudovicRousseau
added a commit
that referenced
this pull request
Jun 29, 2015
Fix or mitigate bare/overgeneral exception handlers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.