Fix most major pylint errors and warnings

5 undefined variables remain unfixed, they appear to be missing
`smartcard.scard.scard` exports
```
************* Module smartcard.pcsc.PCSCReader
E: 67,22: Undefined variable 'SCardIntroduceReader' (undefined-variable)
E: 70,22: Undefined variable 'SCardAddReaderToGroup' (undefined-
variable)
E: 85,22: Undefined variable 'SCardRemoveReaderFromGroup' (undefined-
variable)
************* Module smartcard.pcsc.PCSCReaderGroups
E: 66,22: Undefined variable 'SCardIntroduceReaderGroup' (undefined-
variable)
E: 90,22: Undefined variable 'SCardForgetReaderGroup' (undefined-
variable)
```

smartcard/Card.py

@@ -21,7 +21,6 @@
 along with pyscard; if not, write to the Free Software
 Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
 """
-from smartcard.Exceptions import CardConnectionException, NoCardException
 from smartcard.reader.Reader import Reader
 from smartcard.System import readers
 from smartcard.util import toHexString

smartcard/CardConnection.py

@@ -24,8 +24,6 @@
 """
 
 from smartcard.CardConnectionEvent import CardConnectionEvent
-from smartcard.Exceptions import SmartcardException
-from smartcard.Observer import Observer
 from smartcard.Observer import Observable
 
 

smartcard/CardMonitoring.py

@@ -32,12 +32,9 @@
 from time import sleep
 import traceback
 
-from smartcard.System import readers
-from smartcard.Exceptions import CardRequestTimeoutException
 from smartcard.Observer import Observer
 from smartcard.Observer import Observable
 
-from smartcard.CardType import AnyCardType
 from smartcard.CardRequest import CardRequest
 
 _START_ON_DEMAND_ = False
@@ -216,7 +213,6 @@ def __getattr__(self, name):
 
 
 if __name__ == "__main__":
- from smartcard.CardMonitoring import CardMonitor
  print 'insert or remove cards in the next 10 seconds'
 
  # a simple card observer that prints added/removed cards

smartcard/CardService.py

@@ -30,7 +30,6 @@
 Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
 """
 
-from smartcard.Exceptions import SmartcardException
 from smartcard.scard import *
 
 

smartcard/CardType.py

@@ -21,6 +21,7 @@
 along with pyscard; if not, write to the Free Software
 Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
 """
+from smartcard.Exceptions import InvalidATRMaskLengthException
 from smartcard.System import readers
 from smartcard.util import toHexString
 

smartcard/ClassLoader.py

@@ -9,10 +9,6 @@
 License: PSF license (http:https://docs.python.org/license.html).
 """
 
-import sys
-import types
-
-
 def get_mod(modulePath):
  """Import a module."""
  return __import__(modulePath, globals(), locals(), [''])

smartcard/ExclusiveConnectCardConnection.py

@@ -21,7 +21,6 @@
 along with pyscard; if not, write to the Free Software
 Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
 """
-from smartcard.CardConnection import CardConnection
 from smartcard.CardConnectionDecorator import CardConnectionDecorator
 from smartcard.Exceptions import CardConnectionException
 from smartcard.scard import SCardConnect, SCardDisconnect

smartcard/ExclusiveTransmitCardConnection.py

@@ -21,13 +21,11 @@
 along with pyscard; if not, write to the Free Software
 Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
 """
-from smartcard.CardConnection import CardConnection
 from smartcard.CardConnectionDecorator import CardConnectionDecorator
 from smartcard.Exceptions import CardConnectionException
 from smartcard.scard import SCardBeginTransaction, SCardEndTransaction
 from smartcard.scard import SCARD_LEAVE_CARD
 from smartcard.scard import SCardGetErrorMessage
-from smartcard.pcsc import PCSCCardConnection
 import smartcard.pcsc
 
 

smartcard/Observer.py

@@ -19,7 +19,7 @@
 
 class Observer(object):
 
- def update(observable, arg):
+ def update(self, observable, arg):
  '''Called when the observed object is
  modified. You call an Observable object's
  notifyObservers method to notify all the

smartcard/PassThruCardService.py

@@ -53,7 +53,6 @@ def supports(cardname):
  SELECT = [0xA0, 0xA4, 0x00, 0x00, 0x02]
  DF_TELECOM = [0x7F, 0x10]
  from smartcard.System import readers
- from smartcard.CardConnection import CardConnection
  cc = readers()[0].createConnection()
  cs = PassThruCardService(cc)
  cs.connection.connect()

smartcard/ReaderMonitoring.py

@@ -28,12 +28,11 @@
 Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
 """
 
-from threading import Thread, Event, enumerate
+from threading import Thread, Event
 from time import sleep
 import traceback
 
 import smartcard.System
-from smartcard.Exceptions import ListReadersException
 from smartcard.Observer import Observer
 from smartcard.Observer import Observable
 from smartcard.Synchronization import *
@@ -196,7 +195,6 @@ def stop(self):
  self.join()
 
 if __name__ == "__main__":
- from smartcard.ReaderMonitoring import ReaderMonitor
  print 'insert or remove readers in the next 20 seconds'
 
  # a simple reader observer that prints added/removed readers

smartcard/Session.py

@@ -24,7 +24,6 @@
 """
 
 from smartcard.Exceptions import InvalidReaderException, NoReadersException
-from smartcard.CardConnection import CardConnection
 from smartcard.PassThruCardService import PassThruCardService
 from smartcard.System import readers
 
@@ -110,8 +109,3 @@ def getATR(self):
  def __repr__(self):
  """Returns a string representation of the session."""
  return "<Session instance: readerName=%s>" % self.readerName
-
-
-if __name__ == '__main__':
- """Small sample illustrating the use of Session.py."""
- pass

smartcard/guid.py

@@ -60,7 +60,6 @@ def GUIDToStr(g):
 
 if __name__ == "__main__":
  """Small sample illustrating the use of guid.py."""
- import smartcard.guid
  dummycardguid1 = strToGUID('{AD4F1667-EA75-4124-84D4-641B3B197C65}')
  print dummycardguid1
  print GUIDToStr(dummycardguid1)

smartcard/pcsc/PCSCCardConnection.py

@@ -25,7 +25,6 @@
 from smartcard.CardConnection import CardConnection
 from smartcard.Exceptions import (CardConnectionException,
  NoCardException, SmartcardException)
-from smartcard.Observer import Observable
 
 from smartcard.scard import *
 
@@ -240,8 +239,8 @@ def doGetAttrib(self, attribId):
  """Small sample illustrating the use of CardConnection."""
  SELECT = [0xA0, 0xA4, 0x00, 0x00, 0x02]
  DF_TELECOM = [0x7F, 0x10]
- from smartcard.pcsc.PCSCReader import readers
- cc = readers()[0].createConnection()
+ from smartcard.pcsc.PCSCReader import PCSCReader
+ cc = PCSCReader.readers()[0].createConnection()
  cc.connect()
  print "%r %x %x" % cc.transmit(SELECT + DF_TELECOM)
 

smartcard/pcsc/PCSCPart10.py

@@ -227,8 +227,8 @@ def getTlvProperties(cardConnection, featureList=None, controlCode=None):
 
 if __name__ == '__main__':
  """Small sample illustrating the use of PCSCPart10."""
- from smartcard.pcsc.PCSCReader import readers
- cc = readers()[0].createConnection()
+ from smartcard.pcsc.PCSCReader import PCSCReader
+ cc = PCSCReader.readers()[0].createConnection()
  cc.connect(mode=SCARD_SHARE_DIRECT)
 
  #print cc.control( CM_IOCTL_GET_FEATURE_REQUEST )

smartcard/pyro/PyroReader.py

@@ -25,9 +25,8 @@
 import Pyro.core
 import Pyro.naming
 
-from smartcard.Exceptions import CardConnectionException, NoCardException
+from smartcard.Exceptions import NoCardException
 from smartcard.reader.Reader import Reader
-from smartcard.reader.ReaderFactory import ReaderFactory
 
 
 class PyroReader(Reader):

smartcard/pyro/server/PyroDaemon.py

@@ -85,8 +85,8 @@ def __init__(self):
  Thread.__init__(self)
  self.setDaemon(True)
  self.setName('smartcard.pyro.server.PyroDaemonThread')
- self.daemon = PyroDaemon()
+ self._daemon = PyroDaemon()
 
  def run(self):
  """Starts Pyro daemon."""
- self.daemon.start()
+ self._daemon.start()

smartcard/pyro/server/PyroEventServer.py

@@ -92,7 +92,6 @@ def __call__(self, signame, sf):
 
 
 if __name__ == '__main__':
- import sys
  from smartcard.pyro.server.PyroNameServer import PyroNameServer
  pn = PyroNameServer(sys.argv[1:])
  pn.start()

smartcard/pyro/server/RemoteCardConnection.py

@@ -26,10 +26,7 @@
 import Pyro.core
 import Pyro.naming
 
-from smartcard.CardConnection import CardConnection
 from smartcard.CardConnectionDecorator import CardConnectionDecorator
-from smartcard.Exceptions import CardConnectionException, NoCardException
-from smartcard.Observer import Observable
 
 
 class RemoteCardConnection(CardConnectionDecorator, Pyro.core.ObjBase):

smartcard/pyro/server/RemoteReaderServer.py

@@ -32,10 +32,6 @@
  import sys
  sys.exit()
 
-import signal
-import time
-
-import smartcard.System
 from smartcard.reader.Reader import Reader
 from smartcard.ReaderMonitoring import ReaderMonitor, ReaderObserver
 from smartcard.pyro.server.RemoteCardConnection import RemoteCardConnection

smartcard/reader/ReaderGroups.py

@@ -67,9 +67,6 @@ def __onremoveitem__(self, item):
  def __iter__(self):
  return ulist.__iter__(self)
 
- def next(self):
- return ulist.__next__(self)
-
  #
  # abstract methods implemented in subclasses
  #

smartcard/sw/ErrorChecker.py

@@ -36,7 +36,7 @@ class ErrorChecker(object):
  pattern.
  """
 
- def __call__(data, sw1, sw2):
+ def __call__(self, data, sw1, sw2):
  """Called to test data, sw1 and sw2 for error.
 
  @param data: apdu response data

smartcard/util/__init__.py

@@ -99,7 +99,7 @@ def toBytes(bytestring):
  """
  import struct
  import re
- packedstring = ''.join(re.split('\W+', bytestring))
+ packedstring = ''.join(re.split(r'\W+', bytestring))
  try:
  return reduce(lambda x, y: x + [int(y, 16)],
  struct.unpack('2s' * (len(packedstring) / 2),
@@ -204,9 +204,6 @@ def toHexString(bytes=[], format=0):
 
  from string import rstrip
 
- for byte in tuple(bytes):
- pass
-
  if type(bytes) is not list:
  raise TypeError('not a list of bytes')
 

smartcard/wx/APDUHexValidator.py

@@ -48,7 +48,7 @@ def Clone(self):
 
  def Validate(self, win):
  tc = self.GetWindow()
- val = tc.GetValue()
+ value = tc.GetValue()
 
  if not apduregexp.match(value):
  return False

smartcard/wx/CardAndReaderTreePanel.py

@@ -408,9 +408,9 @@ def __init__(self, parent, appstyle, clientpanel):
  def OnDestroy(self, event):
  """Called on panel destruction."""
  # deregister observers
- if hasattr(self, cardmonitor):
+ if hasattr(self, 'cardmonitor'):
  self.cardmonitor.deleteObserver(self.cardtreecardobserver)
- if hasattr(self, readermonitor):
+ if hasattr(self, 'readermonitor'):
  self.readermonitor.deleteObserver(self.readertreereaderobserver)
  self.cardmonitor.deleteObserver(self.readertreecardobserver)
  event.Skip()

smartcard/wx/ReaderToolbar.py

@@ -77,12 +77,12 @@ def __init__(self, parent):
  bmpReader = wx.Bitmap(ICO_READER, wx.BITMAP_TYPE_ICO)
  else:
  bmpReader = wx.ArtProvider_GetBitmap(
- wx.ART_HELP_BOOK, wx.ART_OTHER, isz)
+ wx.ART_HELP_BOOK, wx.ART_OTHER, tsize)
  if None != ICO_SMARTCARD:
  bmpCard = wx.Bitmap(ICO_SMARTCARD, wx.BITMAP_TYPE_ICO)
  else:
  bmpCard = wx.ArtProvider_GetBitmap(
- wx.ART_HELP_BOOK, wx.ART_OTHER, isz)
+ wx.ART_HELP_BOOK, wx.ART_OTHER, tsize)
  self.readercombobox = ReaderComboBox(self)
 
  # create and add controls

smartcard/wx/SimpleSCardAppFrame.py

@@ -26,10 +26,11 @@
 
 import os.path
 import wx
+
 import smartcard.wx
-import APDUTracerPanel
-import CardAndReaderTreePanel
-import ReaderToolbar
+from smartcard.wx import APDUTracerPanel
+from smartcard.wx import CardAndReaderTreePanel
+from smartcard.wx import ReaderToolbar
 
 import smartcard
 from smartcard.wx.SimpleSCardAppEventObserver import \