Other cleanup #4
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also fixes Mac OS X Lion options being selected on Snow Leopard - due to misordered of elif blocks.
The remaining instance will now print a full traceback. This should improve on with https://sourceforge.net/p/pyscard/bugs/8/, or at least make it easier to solve
5 undefined variables remain unfixed, they appear to be missing `smartcard.scard.scard` exports ``` ************* Module smartcard.pcsc.PCSCReader E: 67,22: Undefined variable 'SCardIntroduceReader' (undefined-variable) E: 70,22: Undefined variable 'SCardAddReaderToGroup' (undefined- variable) E: 85,22: Undefined variable 'SCardRemoveReaderFromGroup' (undefined- variable) ************* Module smartcard.pcsc.PCSCReaderGroups E: 66,22: Undefined variable 'SCardIntroduceReaderGroup' (undefined- variable) E: 90,22: Undefined variable 'SCardForgetReaderGroup' (undefined- variable) ```
…INFO PKG-INFO and included in the sdist package each time setup.py is run. Storing it in source control is redundant.
Add travis-ci status icon
AppVeyor is a Continuous Integration build system for Windows.
The travis-ci icon now links to the project on travis-ci.org
The real name is "Travis CI"
Do not forget to close the file handle when the file can be open correctly.
Use spaces instead of tabs
Some values have been renamed or removed.
This also fixes Mac OS X Lion options being selected on Snow Leopard - due to misordered of elif blocks.
The remaining instance will now print a full traceback. This should improve on with https://sourceforge.net/p/pyscard/bugs/8/, or at least make it easier to solve
5 undefined variables remain unfixed, they appear to be missing `smartcard.scard.scard` exports ``` ************* Module smartcard.pcsc.PCSCReader E: 67,22: Undefined variable 'SCardIntroduceReader' (undefined-variable) E: 70,22: Undefined variable 'SCardAddReaderToGroup' (undefined- variable) E: 85,22: Undefined variable 'SCardRemoveReaderFromGroup' (undefined- variable) ************* Module smartcard.pcsc.PCSCReaderGroups E: 66,22: Undefined variable 'SCardIntroduceReaderGroup' (undefined- variable) E: 90,22: Undefined variable 'SCardForgetReaderGroup' (undefined- variable) ```
In Python 2.6 threading.Thread gained a boolean flag - daemon. https://docs.python.org/2/library/threading.html#threading.Thread.daemon This flag clashes with the daemon attribute of PyroDaemonThread and is likely to cause confusion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are the last few errors found with pylint