Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Draft: NetpuneLogger checkpoint saving reworked #19144

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Draft: NetpuneLogger checkpoint saving reworked #19144

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
0a17fe5
NetpuneLogger checkpoint saving reworked
Raalsky Dec 12, 2023
91f38e6
TODOs removed
Raalsky Dec 12, 2023
cee443f
Parameterize with array
Raalsky Dec 13, 2023
2e97ae4
CHANGELOG
Raalsky Dec 13, 2023
2029c40
Auto review
Raalsky Dec 13, 2023
39564ad
Merge branch 'master' into rj/checkpoint-reworked
Borda Dec 13, 2023
bf11a96
Merge branch 'master' into rj/checkpoint-reworked
Borda Dec 14, 2023
4e17f82
Merge branch 'master' into rj/checkpoint-reworked
Borda Dec 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
TODOs removed
  • Loading branch information
@Raalsky
Raalsky committed Dec 12, 2023
commit 91f38e606e8b86069b373a09cad93a5da0de2664
4 changes: 2 additions & 2 deletions src/lightning/pytorch/loggers/neptune.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -561,8 +561,8 @@ def _delete_old_best_checkpoints(self, new_best_models_names: Set[str], checkpoi
for model_name in tuple(self._uploaded_best_checkpoints - new_best_models_names):
if model_name in self._uploaded_best_checkpoints:
if self.run.exists(f"{checkpoints_namespace}/{model_name}"):
del self.run[f"{checkpoints_namespace}/{model_name}"] # TODO: Cover in tests
self._uploaded_best_checkpoints.remove(model_name) # TODO: Cover in tests
del self.run[f"{checkpoints_namespace}/{model_name}"]
self._uploaded_best_checkpoints.remove(model_name)

@staticmethod
def _get_full_model_name(model_path: str, checkpoint_callback: Checkpoint) -> str:
Expand Down
Loading